-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: actors: manual Ni-PoRep onboarding #12045
Conversation
… feat/remove-markets-provider
All checks have completed ❌ Failed Build / Build (pull_request) |
Oh, and this currently doesn't get past the actors call for NI-PoRep
I believe we should have a single groth16 snark proof that rolls up the new PoRep for the batch (single) case so I that should be Thread about this in Slack @ https://filecoinproject.slack.com/archives/C06EZQ2DTD0/p1716637350693809 |
04b05e6
to
6524ea1
Compare
6524ea1
to
4fe938b
Compare
FWIW this now passes if I comment out this line in actors: https://github.com/filecoin-project/builtin-actors/blob/308f0c06d01ae2fdc017fbe022a077bb972c3991/actors/miner/src/lib.rs#L2004 Discussion still ongoing regarding what the expected sizes are for proofs, but that check probably just needs to be changed to account for single NI-PoRep proof sizes which are much bigger than plain proofs. |
Added support for NI-PoRep in I did break type SealProofVariant int
const (
SealProofVariant_Standard SealProofVariant = iota
SealProofVariant_Synthetic
SealProofVariant_NonInteractive
)
// ...
func SealProofTypeFromSectorSize(ssize abi.SectorSize, nv network.Version, variant SealProofVariant) (abi.RegisteredSealProof, error) {
// ...
} And it does slightly more rigorous checking on what's possible—the variant must be valid for the network version. |
cc7b1b9
to
013b8d1
Compare
013b8d1
to
3b1eaf8
Compare
39fb5cb
to
ad651df
Compare
Status of this is that (for the 3rd time) I'm going to drop this branch and push a new one soon. I've started again locally on top of master because most of the churn that went into this branch has been merged in the |
Replaced by #12105 |
Also adds multi-miner support to the manual test, including async PoST scheduling.
This depends on a bunch of changes elsewhere to work and needs manual wiring up: