-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: itest: fix wdpost proving epoch calculation #12113
Conversation
All checks have passed |
I changed this to wait one challenge window and re-collect deadline |
8b432d3
to
71f8da2
Compare
I have a bit more confidence in this one after tinkering a bit more and grokking actors a bit better. One thing I'm doing now is not hitting the deadline open exactly, but waiting a bit, because I think we might be getting in too quick before cron updates the deadline index in state. It doesn't explain the 47/0 failures specifically but we'll see if that comes back after this. I'll pull it back in to #12105 and continue with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw I ran a number of itest runs since I included this and have not seen the issue crop up again
ironically the test failed in CI for this branch, but it's different I think, might just be a timeout https://github.com/filecoin-project/lotus/actions/runs/9579047475/job/26410654516?pr=12113 |
been re-running in CI and it seems solid; will continue to test in my niporep branch but I think this is good to go |
Fixes: #12091 (I think)
Pulled out of #12105 where I was forced to figure it out and fix it.