Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getMsgInfo returns an ErrNotFound when there are no rows #12680

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

virajbhartiya
Copy link
Member

Related Issues

Closes #12674

Proposed Changes

GetMsgInfo returns an ErrNotFound when there are no rows.

Checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@virajbhartiya virajbhartiya changed the title fix: GetMsgInfo returns an ErrNotFound when there are no rows fix: getMsgInfo returns an ErrNotFound when there are no rows Nov 7, 2024
@github-actions github-actions bot dismissed their stale review November 7, 2024 03:09

PR title now matches the required format.

chain/index/read_test.go Outdated Show resolved Hide resolved
@virajbhartiya
Copy link
Member Author

@rvagg I have done a string comparison to check for the error and return ErrNotFound Please let me know if that's the way to go about it or there's a better way for this

chain/index/read.go Outdated Show resolved Hide resolved
chain/index/read_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@virajbhartiya
Copy link
Member Author

@rvagg I just ran TestEthBlockHashesCorrect_MultiBlockTipset locally that seems to be ✅

@rvagg
Copy link
Member

rvagg commented Nov 21, 2024

Opened a PR for that flaky test @ #12712

@rvagg rvagg merged commit f4dbd88 into filecoin-project:master Nov 21, 2024
80 of 81 checks passed
@virajbhartiya virajbhartiya deleted the getMsgInfo branch November 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

ChainIndexer: GetMsgInfo should return ErrNotFound when not found
2 participants