Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement F3 CLI to list power table and proportional power at instance #12698

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

masih
Copy link
Member

@masih masih commented Nov 14, 2024

Related Issues

Proposed Changes

Implement utility CLIs to:

  • get the power table used by F3 at a given instance ID.
  • get total proportional power of a list of actors at a given instance ID.

These utilities allow us to debug the exact participation power for an instance without having to manually calculate it or estimate it from the latest power.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

Implement utility CLIs to:
* get the power table used by F3 at a given instance ID.
* get total proportional power of a list of actors at a given instance
  ID.

These utilities allow us to debug the exact participation power for an
instance without having to manually calculate it or estimate it from
the latest power.
@masih masih marked this pull request as ready for review November 14, 2024 12:04
@masih masih requested review from rvagg and Kubuxu November 14, 2024 12:04
@masih masih self-assigned this Nov 14, 2024
documentation/en/cli-lotus.md Outdated Show resolved Hide resolved
cli/f3.go Outdated Show resolved Hide resolved
@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 18, 2024

It will be slightly annoying, but can you separate the commands into separate vars? The diff is hard to read because it got too wide.

@masih
Copy link
Member Author

masih commented Nov 18, 2024

can you separate the commands into separate vars?

Sure; done.

@masih
Copy link
Member Author

masih commented Nov 18, 2024

The diff looks more verbose now unfortunately.

If this is hard to review, can break up the vars in a separate PR then rebase this one. Please let me know if you'd prefer it that way @Kubuxu

@masih masih merged commit 2cd6f40 into master Nov 19, 2024
83 checks passed
@masih masih deleted the masih/f3-cli-list-power-table branch November 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants