Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: f3 butterflynet testing #12839

Closed
wants to merge 18 commits into from
Closed

debug: f3 butterflynet testing #12839

wants to merge 18 commits into from

Conversation

masih
Copy link
Member

@masih masih commented Jan 22, 2025

A draft branch to test F3 on butteflynet running the latest unreleased dependencies.

@masih masih changed the title Upgrade to the latest go-f3 and allow F3 chain exchange topics chore: upgrade to the latest go-f3 and allow F3 chain exchange topics Jan 22, 2025
@masih masih self-assigned this Jan 22, 2025
@masih masih force-pushed the masih/f3-dep-up-chainex branch from b2e443d to 0a406e1 Compare January 22, 2025 10:39
@masih masih force-pushed the masih/f3-dep-up-chainex branch 2 times, most recently from fcfeb34 to 90eb3e7 Compare January 31, 2025 09:30
@masih masih force-pushed the masih/f3-dep-up-chainex branch from dc8fe2c to 0b6029d Compare February 3, 2025 13:00
@rjan90 rjan90 mentioned this pull request Feb 4, 2025
8 tasks
rjan90 and others added 6 commits February 4, 2025 12:03
`e232882cba7171e5097b5b12870af19d9256d3a7`
`ac4d25d52d2f48285b503046e3d30ae766ee7ffa`
Log failure to run CLI command

Prior code only conditionally logged the output when `LOTUS_DEV` env
var was present. This doesn't make sense for a number of reasons:

* In case of an error starting up `lotus daemon` via systemctl for
  example the logs would miss the error. One then has to search through
  system journal to see what happened.

* There are no other places that I can find where `LOTUS_DEV` env var is
  used. The commit that introduced this condition is very old with no
  clear commit message to shed light into the rationale.

For the first reason alone, the changes here remove that condition, and
log the message when the logging output is not standard err or out. This
way we at least cover the case where lotus is run in a production
environment and would avoid partial logging of errors.

(cherry picked from commit bb70977)
`a2b3c6601f7fe4375e51b939ae86bd4638916060`
@masih masih changed the title chore: upgrade to the latest go-f3 and allow F3 chain exchange topics debug: f3 butterflynet testing Feb 11, 2025
@masih masih closed this Feb 24, 2025
@masih masih deleted the masih/f3-dep-up-chainex branch February 24, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants