Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to rust 1.81.0 #2109

Merged
merged 3 commits into from
Apr 1, 2025
Merged

chore: update to rust 1.81.0 #2109

merged 3 commits into from
Apr 1, 2025

Conversation

Stebalien
Copy link
Member

Matches builtin actors and fixes cargo-deny.

@Stebalien Stebalien changed the title update to rust 1.81.0 chore: update to rust 1.81.0 Mar 14, 2025
@Stebalien Stebalien requested a review from BigLep March 14, 2025 16:53
@BigLep BigLep requested a review from rjan90 March 14, 2025 17:03
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per 2025-03-14 verbal with @rjan90 , @ZenGround0 , and @Stebalien

@Stebalien
Copy link
Member Author

Ok, this is going to take some more work.

@Stebalien Stebalien marked this pull request as draft March 14, 2025 18:54
@Stebalien
Copy link
Member Author

I'm going to need to make a few fixes here. So I'll do this in the next release and we'll just have to live with cargo-deny failing (that's fine, tbh).

@rvagg
Copy link
Member

rvagg commented Mar 21, 2025

@Stebalien I hope you don't mind but I pushed a commit here to make it happier; I'd like to get back to tinkering with #2101 but I get errors all over my IDE due to ABI mismatches because of the old Rust version and would like to not have to deal with any of that so I'll work on top of this branch instead.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.85%. Comparing base (aaf5155) to head (7728aae).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
ipld/kamt/src/bitfield.rs 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2109      +/-   ##
==========================================
- Coverage   75.95%   75.85%   -0.11%     
==========================================
  Files         154      154              
  Lines       15772    15541     -231     
==========================================
- Hits        11980    11788     -192     
+ Misses       3792     3753      -39     
Files with missing lines Coverage Δ
fvm/src/engine/mod.rs 86.14% <100.00%> (-0.43%) ⬇️
fvm/src/executor/mod.rs 21.21% <ø> (ø)
fvm/src/kernel/filecoin.rs 19.89% <ø> (ø)
fvm/src/syscalls/filecoin.rs 18.79% <ø> (ø)
ipld/amt/src/lib.rs 94.11% <100.00%> (ø)
ipld/hamt/src/bitfield.rs 90.97% <100.00%> (ø)
sdk/src/crypto.rs 0.00% <ø> (ø)
shared/src/address/payload.rs 75.23% <ø> (-0.24%) ⬇️
shared/src/address/protocol.rs 100.00% <ø> (ø)
ipld/kamt/src/bitfield.rs 84.71% <0.00%> (ø)

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rvagg rvagg force-pushed the steb/update-rust branch 2 times, most recently from 7e18fed to 7728aae Compare March 21, 2025 04:08
@rvagg
Copy link
Member

rvagg commented Mar 21, 2025

ok, clippy is really annoying to run in this environment .. 🤞

@Stebalien
Copy link
Member Author

I've filed bytecodealliance/wasmtime#10454. Our use of features here wasn't effective anyways.

@rvagg
Copy link
Member

rvagg commented Mar 31, 2025

@Stebalien should we just merge this as is now? I think we agreed last week we should get this one done and follow-up later if we get the wasmtime change figured out

@Stebalien Stebalien marked this pull request as ready for review April 1, 2025 23:14
@Stebalien Stebalien merged commit da207f4 into master Apr 1, 2025
15 checks passed
@Stebalien Stebalien deleted the steb/update-rust branch April 1, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

5 participants