This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
trying to reduce window periods #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2020 19:54
It will be used in the current effort of setting sane values for gas. Virtual gas is added for observing how changes to gas numbers affect the balance without affecting the stateroot of the chain. Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
nonsense
force-pushed
the
reduce-wpostprovingperiod-consts
branch
from
068f482 to
fef6656
Compare
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 43.22% 43.25% +0.02%
==========================================
Files 40 40
Lines 4393 4400 +7
==========================================
+ Hits 1899 1903 +4
- Misses 2214 2216 +2
- Partials 280 281 +1 |
nonsense
force-pushed
the
reduce-wpostprovingperiod-consts
branch
from
fef6656 to
6a2de25
Compare
Closed
3 tasks
|
@nonsense could we close this PR? My impression is that there's no intention of this going into |
|
@anorth sure, I will close it. Depending on how well our tests work with filecoin-project/oni#143 (mock time), we might be able to use the production windows (deadlines). For now I continue to override the deadlines, but I don't need an open PR for that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to reduce the various periods in
specs-actors, so that we can test various behaviours in Project Oni, without having to wait for thousands of epochs.There has been some success when reducing the
WPoStProvingPeriodto 360 andWPoStChallengeWindowto 10, but it is not yet clear if this introduces other issues.In the future we will probably also want to reduce
FaultMaxAgeI also considered changing
consts tovars, but this is not possible, since we allocate arrays with const sizes. I am not aware of any other way to change these, but to introduce build flags, similar to what we already did on Lotus side (for example https://github.com/filecoin-project/lotus/blob/master/build/params_testground.go)Related: filecoin-project/oni#12
cc @raulk