Naming & Comments

files-community · Nov 24, 2024 · 4926a33 · yaira2 · Nov 25, 2024 · 4926a33
1 parent db75b2e
commit 4926a33
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/src/Files.App/Data/Enums/PreviewPaneStates.cs b/src/Files.App/Data/Enums/PreviewPaneStates.cs
@@ -36,6 +36,6 @@ public enum PreviewPaneStates
 		/// <summary>
 		/// Drive preview and details available status.
 		/// </summary>
-		DrivePreviewAndDetailsAvailable,
+		DriveStorageDetailsAvailable,
 	}
 }
diff --git a/src/Files.App/UserControls/Pane/InfoPane.xaml b/src/Files.App/UserControls/Pane/InfoPane.xaml
@@ -302,7 +302,7 @@
 					</Grid.ColumnDefinitions>
 
 					<TextBlock
-						x:Name="AvailableSpaceTextBox"
+						x:Name="AvailableSpaceTextBlock"
 						FontFamily="{ThemeResource ContentControlThemeFontFamily}"
 						FontSize="14"
 						FontWeight="Bold"
@@ -573,7 +573,7 @@
 						<Setter Target="PreviewLoadingIndicator.Visibility" Value="Visible" />
 					</VisualState.Setters>
 				</VisualState>
-				<VisualState x:Name="DrivePreviewAndDetailsAvailable">
+				<VisualState x:Name="DriveStorageDetailsAvailable">
 					<VisualState.StateTriggers>
 						<triggers:IsEqualStateTrigger Value="{x:Bind ViewModel.PreviewPaneState, Mode=OneWay}" To="5" />
 					</VisualState.StateTriggers>

diff --git a/src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs b/src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs
@@ -191,7 +191,7 @@ private async Task LoadPreviewControlAsync(CancellationToken token, bool downloa
 			if (control is not null)
 			{
 				PreviewPaneContent = control;
-				PreviewPaneState = SelectedItem.IsDriveRoot ? PreviewPaneStates.DrivePreviewAndDetailsAvailable : PreviewPaneStates.PreviewAndDetailsAvailable;
+				PreviewPaneState = SelectedItem.IsDriveRoot ? PreviewPaneStates.DriveStorageDetailsAvailable : PreviewPaneStates.PreviewAndDetailsAvailable;
 				return;
 			}
 
@@ -204,7 +204,7 @@ private async Task LoadPreviewControlAsync(CancellationToken token, bool downloa
 				return;
 
 			PreviewPaneContent = control;
-			PreviewPaneState = SelectedItem.IsDriveRoot ? PreviewPaneStates.DrivePreviewAndDetailsAvailable : PreviewPaneStates.PreviewAndDetailsAvailable;
+			PreviewPaneState = SelectedItem.IsDriveRoot ? PreviewPaneStates.DriveStorageDetailsAvailable : PreviewPaneStates.PreviewAndDetailsAvailable;
 		}
 
 		private async Task<UserControl> GetBuiltInPreviewControlAsync(ListedItem item, bool downloadItem)

diff --git a/src/Files.App/ViewModels/UserControls/Previews/FolderPreviewViewModel.cs b/src/Files.App/ViewModels/UserControls/Previews/FolderPreviewViewModel.cs
@@ -36,6 +36,9 @@ private async Task LoadPreviewAndDetailsAsync()
 			if (result is not null)
 				Thumbnail = await result.ToBitmapAsync();
 
+			// If the selected item is the root of a drive (e.g. "C:\")
+			// we do not need to load the properties below, since they will not be shown.
+			// Drive properties will be obtained through the DrivesViewModel service.
 			if (Item.IsDriveRoot)
 				return;