Skip to content

Code Quality: Migrated CopyFileFromApp and MoveFileFromApp to CsWin32 #15131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

gumbarros
Copy link
Contributor

@gumbarros gumbarros commented Apr 7, 2024

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great choice for the first step!

It looks very good!!
Replacing with it won't affect on behavior because both DllImport and CsWin32 use P/Invoke if the project can be build.

@0x5bfa
Copy link
Member

0x5bfa commented Apr 7, 2024

I think you can put more two DeleteFileFromApp and DeleteFolderFromApp.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 7, 2024
@yaira2 yaira2 merged commit 938aaa7 into files-community:main Apr 7, 2024
6 checks passed
@yaira2
Copy link
Member

yaira2 commented Apr 7, 2024

I think you can put more two DeleteFileFromApp and DeleteFolderFromApp.

Let's try to keep these PRs small in scope to make the review easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants