Code Quality: Introduced IWindowsWallpaperService #15811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I thought this also can be in WindowsShellService since this is shell features (except Lock Screen). This is about just like or dislike. Whatever opinion is welcome. |
yaira2
force-pushed
the
main
branch
2 times, most recently
from
ff65c93 to
8097ba8
Compare
yaira2
reviewed
Jul 17, 2024
|
0x5bfa
force-pushed
the
5bfa/CQ-IWindowsWallpaperService
branch
from
047bb7e to
48f3173
Compare
|
Alright, ready for review. |
yaira2
reviewed
Jul 21, 2024
yaira2
reviewed
Jul 21, 2024
src/Files.App/Actions/Content/Background/SetAsWallpaperBackgroundAction.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Jul 21, 2024
src/Files.App/Actions/Content/Background/SetAsWallpaperBackgroundAction.cs
Outdated
Show resolved
Hide resolved
…undAction.cs Co-authored-by: Yair <[email protected]>
…undAction.cs Co-authored-by: Yair <[email protected]>
yaira2
approved these changes
Jul 21, 2024
yaira2
added
the
ready to merge
yaira2
pushed a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolved / Related Issues
Steps used to test these changes