Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Adding ToolbarButton controls #15894

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Code Quality: Adding ToolbarButton controls #15894

wants to merge 29 commits into from

Commits on Jul 30, 2024

  1. Initial check in for ToolbarButton controls

    @mdtauk
    mdtauk committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7ab861b View commit details
    Browse the repository at this point in the history

  2. Added VisualState constants for ToolbarFlyoutButton

    @mdtauk
    mdtauk committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ea4132e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Changed the placeholders to derive from CommandBar and AppBarButtons

    @mdtauk
    mdtauk committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    043af93 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Removed the CommandBar and AppBar 

    This is assuming we are building a control from scratch.  Code is mostly placeholder and dependency property frameworks
    @mdtauk
    mdtauk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    db09bec View commit details
    Browse the repository at this point in the history

  2. Some more framework adding

    @mdtauk
    mdtauk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    43d98b3 View commit details
    Browse the repository at this point in the history

  3. Moved Lists to the main Toolbar Folder

    @mdtauk
    mdtauk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a6cbd02 View commit details
    Browse the repository at this point in the history

  4. Update ToolbarItemTypes.cs

    @mdtauk
    mdtauk committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d58a3e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Filling in more Properties and framework events

    @mdtauk
    mdtauk committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    56873bb View commit details
    Browse the repository at this point in the history

  2. Replaced Toolbar.Items with ItemsSource 

    Not sure if this is the right approach, but I've done it for now.  ToolbarItem should be an abstract and the Toolbar control translates them into Buttons and Menu Items
    @mdtauk
    mdtauk committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    e123178 View commit details
    Browse the repository at this point in the history

  3. Added basic ToolbarToggleButton template

    @mdtauk
    mdtauk committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    cc39610 View commit details
    Browse the repository at this point in the history

  4. Beginnings of Toolbar Items property, and ItemsRepeater showing items

    @mdtauk
    mdtauk committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    046572d View commit details
    Browse the repository at this point in the history

  5. Formatted Xaml

    @mdtauk
    mdtauk committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    c4426f3 View commit details
    Browse the repository at this point in the history

  6. Started adding barebones code for Toolbar Items sorting

    @mdtauk
    mdtauk committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    337574e View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Added SubItems property to ToolbarItem

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    c0b9209 View commit details
    Browse the repository at this point in the history

  2. Added ToolbarSeparator and moved some sub folders

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    ac8f527 View commit details
    Browse the repository at this point in the history

  3. added muxc xml namespace to ThemeResource files

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    3f7c5f3 View commit details
    Browse the repository at this point in the history

  4. Starting work on fixing Tabbing issues

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    5906f20 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into mdta-ToolbarButtons

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    1333811 View commit details
    Browse the repository at this point in the history

  6. Update App.xaml.cs 

    Set the window size to be more mangable whilst debugging lol
    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    1e92f5c View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into mdta-ToolbarButtons

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    ef9a4b9 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into mdta-ToolbarButtons

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    df838bb View commit details
    Browse the repository at this point in the history

  9. Basic Populating of ItemsRepeater from code and Private List 

    Basic creation of controls with sizes based on ToolbarSize - we need to re-draw or update controls within the lists if the ToolbarSize changes at runtime
    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    0328429 View commit details
    Browse the repository at this point in the history

  10. Formatted

    @mdtauk
    mdtauk committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    7dc6176 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Updated Toolbar Button and Toggle Button visuals

    @mdtauk
    mdtauk committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a5e6954 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge remote-tracking branch 'upstream/main' into mdta-ToolbarButtons

    @mdtauk
    mdtauk committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    536beed View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge remote-tracking branch 'upstream/main' into mdta-ToolbarButtons

    @mdtauk
    mdtauk committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    73141d4 View commit details
    Browse the repository at this point in the history

  2. Updated Toolbar examples to Page 

    Also added an IsChecked property to ToolbarItem to be passed onto the Toggle ItemTypes
    @mdtauk
    mdtauk committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5fd3328 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Formatted XAML/C#

    @0x5bfa
    0x5bfa committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    96460ac View commit details
    Browse the repository at this point in the history

  2. Update

    @0x5bfa
    0x5bfa committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4cfa419 View commit details
    Browse the repository at this point in the history