Code Quality: Assigned execution alias and URI for each build #16182
Conversation
0x5bfa
force-pushed
the
5bfa/CQ-SeparatedAppAlias
branch
from
7b72fbe
to
fbb78ae
Compare
0x5bfa
changed the title
| $ap = $xmlDoc.SelectSingleNode("/pkg:Package/pkg:Applications/pkg:Application/pkg:Extensions/uap:Extension[@Category='windows.protocol']/uap:Protocol", $nsmgr) | ||
| $aea = $xmlDoc.SelectSingleNode("/pkg:Package/pkg:Applications/pkg:Application/pkg:Extensions/uap5:Extension[@Category='windows.appExecutionAlias']/uap5:AppExecutionAlias/uap5:ExecutionAlias", $nsmgr) | ||
| $ap.SetAttribute("Name", "files"); | ||
| $aea.SetAttribute("Alias", "files.exe"); |
There was a problem hiding this comment.
Considering that we've decided to keep files.exe for backwards compatibility, will this duplicate definition cause issues?
There was a problem hiding this comment.
Maybe, maybe not. If that might happen we could remove that in Stable/Store release,
There was a problem hiding this comment.
I think we need to remove it for the stable release
There was a problem hiding this comment.
Done. Btw I renamed protocol to files-dev, files-preview and files instead of files-uwp. This alone doesn't need backward compatibility?
There was a problem hiding this comment.
Unless @hishitetsu sees an issue with it, I think files-uwp can be removed.
There was a problem hiding this comment.
I think files-uwp should also be kept for backward compatibility. It is not a public feature, but someone may have written scripts using this URI scheme.
Also, I think files is a too generic term for a URI scheme and may be confused with file URI scheme. So I think files-app, files-app-stable, files-app-preview, files-app-dev are better.
There was a problem hiding this comment.
I personally prefer files, as it's short and easy to type, but I'm not set on it.
There was a problem hiding this comment.
Easy to change before we merge this.
I'll test this again later.
Also, I'm not sure we can set more than one protocol.
There was a problem hiding this comment.
Also, I'm not sure we can set more than one protocol.
I've confirmed that it works fine even if the app has mutiple protocols.
I believe each build should have these aliases and URI schemes.
- Alias
| Build | files.exe | files-stable.exe | files-preview.exe | files-dev.exe |
|---|---|---|---|---|
| Stable | o | o | ||
| Preview | o | o | ||
| Dev | o | o |
- URI scheme
| Build | files: | files-uwp: | files-stable: | files-preview: | files-dev: |
|---|---|---|---|---|---|
| Stable | o | o | o | ||
| Preview | o | o | o | ||
| Dev | o | o | o |
Co-authored-by: Yair <[email protected]>
yaira2
added
changes requested
Resolved / Related Issues
Steps used to test these changes
None