Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Replace 'Format Drive' commands with actions #16468

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 14, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed the options worked correctly from the sidebar, toolbar, command palette, and home page.

@yaira2 yaira2 changed the title Code Quality: Replace 'Format Drive[ commands with actions Code Quality: Replace 'Format Drive' commands with actions Nov 14, 2024
@yaira2 yaira2 requested a review from 0x5bfa November 14, 2024 15:53
@yaira2 yaira2 changed the title Code Quality: Replace 'Format Drive' commands with actions Feature: Added drive related actions to the toolbar Nov 14, 2024
@yaira2 yaira2 changed the title Feature: Added drive related actions to the toolbar Code Quality: Replace 'Format Drive' commands with actions Nov 14, 2024
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, code wise.

@yaira2 yaira2 merged commit 7282b47 into main Nov 14, 2024
8 checks passed
@yaira2 yaira2 deleted the ya/FormatDriveAction branch November 14, 2024 23:51
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add drive-related options to toolbar and context menu
2 participants