Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Replaced Home and Sidebar commands with actions #16484

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 18, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Tested modified actions from each context

@yaira2 yaira2 marked this pull request as draft November 18, 2024 21:25
@yaira2 yaira2 changed the title Code Quality: Replaced home page commands with actions Code Quality: Replaced Home and Sidebar commands with actions Nov 18, 2024
@yaira2 yaira2 requested a review from 0x5bfa November 18, 2024 21:40
@yaira2 yaira2 marked this pull request as ready for review November 18, 2024 21:40
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, code wise.

@yaira2 yaira2 merged commit 415c6ba into main Nov 19, 2024
8 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 19, 2024
@yaira2 yaira2 deleted the ya/Commands branch November 19, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants