Feature: Display drive information in Details Pane #16513
Conversation
| /// <summary> | ||
| /// Drive preview and details available status. | ||
| /// </summary> | ||
| DrivePreviewAndDetailsAvailable, |
There was a problem hiding this comment.
| DrivePreviewAndDetailsAvailable, | |
| DriveStorageDetailsAvailable, |
| @@ -39,6 +36,9 @@ private async Task LoadPreviewAndDetailsAsync() | |||
| if (result is not null) | |||
| Thumbnail = await result.ToBitmapAsync(); | |||
|
|
|||
| if (Item.IsDriveRoot) | |||
There was a problem hiding this comment.
Can you add a code comment for future reference?
| </Grid.ColumnDefinitions> | ||
|
|
||
| <TextBlock | ||
| x:Name="AvailableSpaceTextBox" |
There was a problem hiding this comment.
| x:Name="AvailableSpaceTextBox" | |
| x:Name="AvailableSpaceTextBlock" |
| <TextBlock | ||
| x:Name="DriveFormatTextBox" | ||
| HorizontalAlignment="Center" | ||
| FontFamily="{ThemeResource ContentControlThemeFontFamily}" | ||
| FontSize="14" | ||
| IsTextSelectionEnabled="True" | ||
| Text="{x:Bind ViewModel.SelectedDriveItem.Filesystem, Mode=OneWay}" | ||
| TextAlignment="Center" | ||
| TextWrapping="Wrap" /> | ||
| <TextBlock | ||
| x:Name="DriveTypeTextBox" | ||
| HorizontalAlignment="Center" | ||
| FontFamily="{ThemeResource ContentControlThemeFontFamily}" | ||
| FontSize="14" | ||
| Foreground="{ThemeResource TextFillColorTertiaryBrush}" | ||
| IsTextSelectionEnabled="True" | ||
| Text="{x:Bind ViewModel.SelectedDriveItem.TypeText, Mode=OneWay}" | ||
| TextAlignment="Center" | ||
| TextWrapping="Wrap" /> |
There was a problem hiding this comment.
It looks like there can be some responsiveness issues here and we might need word wrapping. Can these be combined into a single TextBlock? You can still achieve the styling by using multiple runs.
There was a problem hiding this comment.
Is spacing sufficient in the first picture or should I go with the second?
There was a problem hiding this comment.
The issue was less with the spacing and more that it gets cut off on the sides.
There was a problem hiding this comment.
My bad, I wasn't clear: both the pictures above are using a single TextBlock.
The difference is that in the second one I added a Run containing a white space
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
Notes
I have NOT tested this feature with
Network Drivessince I have none