-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the code and speed of ToStorageItem<TOut>() #4346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2dyno1
changed the title
Improve the code for ToStorageItem<TOut>()
Improve the code and speed of ToStorageItem<TOut>()
Mar 28, 2021
d2dyno1
changed the title
Improve the code and speed of ToStorageItem<TOut>()
Improved the code and speed of ToStorageItem<TOut>()
Mar 28, 2021
Ready! |
lukeblevins
reviewed
Mar 28, 2021
lukeblevins
previously approved these changes
Mar 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. For those unfamiliar, @d2dyno1 and I discussed privately in chat how this PR reduces the calls to intensive functions pertaining to filesystem access.
@duke7553
|
yaira2
reviewed
Mar 30, 2021
yaira2
approved these changes
Mar 30, 2021
lukeblevins
approved these changes
Mar 30, 2021
lukeblevins
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of Changes
This PR improves the code and speed of
ToStorageItem<TOut>()
.Since getting instances of
StorageFile
andStorageFolder
is resource heavy and slow, this PR mitigates the performance hole as much as possible.Bundles widget heavily relies on this function and the performance increase is very noticeable (It's "you could test debug app against release app" noticeable)
For #4180
Validation
How did you test these changes?