Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidManifest.xml for Android S #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caraesten
Copy link

The latest version of Android requires all activities that use an intent-filter to specify whether or not they're exported (https://developer.android.com/about/versions/12/behavior-changes-12#exported).

Currently, anyone using filestack-android will have their build broken when compiling for S

The latest version of Android requires all activities that use an intent-filter to specify whether or not they're exported (https://developer.android.com/about/versions/12/behavior-changes-12#exported).

Currently, anyone using filestack-android will have their build broken when compiling for S
@shiik0
Copy link

shiik0 commented May 6, 2022

Hi!

I'm working on an application that is aiming for the version 32 of the android SDK, so the master branch breaks my build currently. Already tested the branch from this PR and now everything is working properly! So it would be great if this PR is merged. Is that possible?

@scana I noticed that you made the last release. Are you the maintainer of this project or can you point me to who is the current maintainer? Much appreciated 😄

@scana
Copy link
Contributor

scana commented May 18, 2022

@shiik0 hi! Sorry, I am no a longer maintainer of this project - not sure if anyone took over after I left.

I would suggest forking this repository on your own or contacting user support through https://www.filestack.com/.

As an alternative, you can re-declare this Activity in your main AndroidManifest.xml and the end result should be merged:

<activity
  android:name="com.filestack.android.FsActivity"
  android:exported="true"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants