Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making simple-process-stats optional #33

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

jondot
Copy link
Contributor

@jondot jondot commented Nov 22, 2023

Hi,
There is a dependency issue, which causes unresolvable Cargo conflicts on macOS caused by a transitive dependency of simple-process-stats:

  • see upgrade memchr dependency heim-rs/darwin-libproc#9 on the core dependency issue, and the fact that darwin-libproc is not maintained actively to fix it
  • sidekiq-rs needs robotty/simple-process-stats which depends on darwin-libproc, which depends on
    a too old memchr version which many libraries, one example: sqlx needs. because libproc is native and not pure rust, cargo cannot resolve it.

since simple_process_stats use by sidekiq-rs is minimal only for getting RSS, its better to replace it with something that has more velocity on updating dependencies but that is also lightweight and cross platform (I didn't find one yet).

in the meanwhile as a workaround, I put the dependency under an optional flag -- enabled by a feature. this feature is by-default turned on so no one will notice.

in our codebase, we can disable this feature, which disables simple-process-stats, and our build passes nicely.

@film42
Copy link
Owner

film42 commented Nov 22, 2023

Looks great. Going to add a comment at the cfg to state why and under what conditions this can be removed. Thank you!

@film42 film42 merged commit c7b09c4 into film42:master Nov 22, 2023
1 check passed
@film42
Copy link
Owner

film42 commented Nov 22, 2023

Released as 0.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants