making simple-process-stats optional #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There is a dependency issue, which causes unresolvable Cargo conflicts on macOS caused by a transitive dependency of
simple-process-stats
:darwin-libproc
is not maintained actively to fix itrobotty/simple-process-stats
which depends ondarwin-libproc
, which depends ona too old
memchr
version which many libraries, one example:sqlx
needs. becauselibproc
is native and not pure rust, cargo cannot resolve it.since
simple_process_stats
use bysidekiq-rs
is minimal only for gettingRSS
, its better to replace it with something that has more velocity on updating dependencies but that is also lightweight and cross platform (I didn't find one yet).in the meanwhile as a workaround, I put the dependency under an optional flag -- enabled by a feature. this feature is by-default turned on so no one will notice.
in our codebase, we can disable this feature, which disables
simple-process-stats
, and our build passes nicely.