Skip to content

Commit

Permalink
feat: syncer: optimize syncFork for one-epoch forks
Browse files Browse the repository at this point in the history
  • Loading branch information
arajasek committed Dec 15, 2023
1 parent fac1d11 commit e473571
Showing 1 changed file with 29 additions and 0 deletions.
29 changes: 29 additions & 0 deletions chain/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,35 @@ func (syncer *Syncer) syncFork(ctx context.Context, incoming *types.TipSet, know
}
}

incomingParentsTsk := incoming.Parents()
commonParent := false
for _, incomingParent := range incomingParentsTsk.Cids() {
if known.Contains(incomingParent) {
commonParent = true
}
}

if commonParent {
// known contains at least one of incoming's Parents => the common ancestor is known's Parents (incoming's Grandparents)
// in this case, we need to return {incoming, incoming.Parents()}
incomingParents, err := syncer.store.LoadTipSet(ctx, incomingParentsTsk)
if err != nil {
// fallback onto the network
tips, err := syncer.Exchange.GetBlocks(ctx, incoming.Parents(), 1)
if err != nil {
return nil, xerrors.Errorf("failed to fetch incomingParents from the network: %w", err)
}

if len(tips) == 0 {
return nil, xerrors.Errorf("network didn't return any tipsets")
}

incomingParents = tips[0]
}

return []*types.TipSet{incoming, incomingParents}, nil
}

// TODO: Does this mean we always ask for ForkLengthThreshold blocks from the network, even if we just need, like, 2? Yes.
// Would it not be better to ask in smaller chunks, given that an ~ForkLengthThreshold is very rare?
tips, err := syncer.Exchange.GetBlocks(ctx, incoming.Parents(), int(build.ForkLengthThreshold))
Expand Down

0 comments on commit e473571

Please sign in to comment.