refactor(cassandra): Mark queries as idempotent to enable retries #1575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior :
Idempotence is not explicitly set on any prepared statements for the queries.
Datastax specifies that by default queries are not marked as idempotent unless overridden at the session level.
Because of this the queries won't be retried according to the retry policy.
Reference: https://docs.datastax.com/en/developer/java-driver/3.6/manual/idempotence/#query-idempotence
Quote from above:
New behavior :
Setting idempotent explicitly to true will enable the retry policy to act on these queries.
Note:
The queries have all been deemed to be idempotent. Please review individual queries carefully to verify that assertion.