Move juliapkg.json file to src/finch
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameerabbasi
reviewed
Mar 5, 2025
mtsokol
force-pushed
the
juliapkg-file
branch
2 times, most recently
from
c087ba1 to
37cd49c
Compare
hameerabbasi
changed the title
juliapkg.json to tool.poetry.packagesjuliapkg.json to tool.poetry.include
hameerabbasi
approved these changes
Mar 5, 2025
|
I still had to fix a typo, so I updated the commit message already. |
|
I guess now we also need to move the JSON and update all references to it. Or somehow specify a source or target. |
mtsokol
changed the title
juliapkg.json to tool.poetry.includejuliapkg.json file to src/finch
|
Thanks, @mtsokol! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hameerabbasi After checking pydata/sparse#846 it looks like
juliapkg.jsonisn't present in the wheel, causing missing Julia dependencies. Let's try by adding the file to theinclude.