feat: implement auto approval with pre-receive hooks

cypress/e2e/autoApproved.cy.js

@@ -0,0 +1,72 @@
+import moment from 'moment';
+
+describe('Auto-Approved Push Test', () => {
+  beforeEach(() => {
+    cy.intercept('GET', '/api/v1/push/123', {
+      statusCode: 200,
+      body: {
+        steps: [
+          {
+            stepName: 'diff',
+            content: '',
+          },
+        ],
+        error: false,
+        allowPush: true,
+        authorised: true,
+        canceled: false,
+        rejected: false,
+        autoApproved: true,
+        autoRejected: false,
+        commitFrom: 'commitFrom',
+        commitTo: 'commitTo',
+        branch: 'refs/heads/main',
+        user: 'testUser',
+        id: 'commitFrom__commitTo',
+        type: 'push',
+        method: 'POST',
+        timestamp: 1696161600000,
+        project: 'testUser',
+        repoName: 'test.git',
+        url: 'https://github.com/testUser/test.git',
+        repo: 'testUser/test.git',
+        commitData: [
+          {
+            tree: '1234',
+            parent: '12345',
+          },
+        ],
+        attestation: {
+          timestamp: '2023-10-01T12:00:00Z',
+          autoApproved: true,
+        },
+      },
+    }).as('getPush');
+  });
+
+  it('should display auto-approved message and verify tooltip contains the expected timestamp', () => {
+    cy.visit('/admin/push/123');
+
+    cy.wait('@getPush');
+
+    cy.contains('Auto-approved by system').should('be.visible');
+
+    cy.get('svg.MuiSvgIcon-root')
+      .filter((_, el) => getComputedStyle(el).fill === 'rgb(0, 128, 0)')
+      .invoke('attr', 'style')
+      .should('include', 'cursor: default')
+      .and('include', 'opacity: 0.5');
+
+    const expectedTooltipTimestamp = moment('2023-10-01T12:00:00Z')
+      .local()
+      .format('dddd, MMMM Do YYYY, h:mm:ss a');
+
+    cy.get('kbd')
+      .trigger('mouseover')
+      .then(() => {
+        cy.get('.MuiTooltip-tooltip').should('contain', expectedTooltipTimestamp);
+      });
+
+    cy.contains('approved this contribution').should('not.exist');
+  });
+});

src/proxy/actions/Action.js

@@ -14,6 +14,8 @@
   authorised = false;
   canceled = false;
   rejected = false;
+  autoApproved = false;
+  autoRejected = false;
   commitFrom;
   commitTo;
   branch;
@@ -104,6 +106,19 @@
     this.blocked = false;
   }
 
+  /**
+   *`
+   */
+  setAutoApproval() {
+    this.autoApproved = true;
+  }
+
+  /**
+   *`
+   */
+  setAutoRejection() {
+    this.autoRejected = true;
+  }
   /**
    * @return {bool}
    */

src/proxy/actions/autoActions.js

@@ -0,0 +1,38 @@
+const db = require('../../db');
+
+const attemptAutoApproval = async (action) => {
+  try {
+    const attestation = {
+      timestamp: new Date(),
+      autoApproved: true,
+    };
+    await db.authorise(action.id, attestation);
+    console.log('Push automatically approved by system.');
+
+    return true;
+  } catch (error) {
+    console.error('Error during auto-approval:', error.message);
+    return false;
+  }
+};
+
+const attemptAutoRejection = async (action) => {
+  try {
+    const attestation = {
+      timestamp: new Date(),
+      autoApproved: true,
+    };
+    await db.reject(action.id, attestation);
+    console.log('Push automatically rejected by system.');
+
+    return true;
+  } catch (error) {
+    console.error('Error during auto-rejection:', error.message);
+    return false;
+  }
+};
+
+module.exports = {
+  attemptAutoApproval,
+  attemptAutoRejection,
+};

src/proxy/chain.js

@@ -1,4 +1,5 @@
 const proc = require('./processors');
+const { attemptAutoApproval, attemptAutoRejection } = require('./actions/autoActions');
 
 const pushActionChain = [
   proc.push.parsePush,
@@ -40,6 +41,11 @@ const executeChain = async (req) => {
     }
   } finally {
     await proc.push.audit(req, action);
+    if (action.autoApproved) {
+      attemptAutoApproval(action);
+    } else if (action.autoRejected) {
+      attemptAutoRejection(action);
+    }
   }
 
   return action;

src/proxy/processors/push-action/preReceive.js

@@ -9,6 +9,7 @@ const sanitizeInput = (_req, action) => {
 
 const exec = async (req, action, hookFilePath = './hooks/pre-receive.sh') => {
   const step = new Step('executeExternalPreReceiveHook');
+  let stderrTrimmed = '';
 
   try {
     const resolvedPath = path.resolve(hookFilePath);
@@ -34,23 +35,33 @@ const exec = async (req, action, hookFilePath = './hooks/pre-receive.sh') => {
 
     const { stdout, stderr, status } = hookProcess;
 
-    const stderrTrimmed = stderr ? stderr.trim() : '';
+    stderrTrimmed = stderr ? stderr.trim() : '';
     const stdoutTrimmed = stdout ? stdout.trim() : '';
 
-    if (status !== 0) {
+    step.log(`Hook exited with status ${status}`);
+
+    if (status === 0) {
+      step.log('Push automatically approved by pre-receive hook.');
+      action.addStep(step);
+      action.setAutoApproval();
+    } else if (status === 1) {
+      step.log('Push automatically rejected by pre-receive hook.');
+      action.addStep(step);
+      action.setAutoRejection();
+    } else if (status === 2) {
+      step.log('Push requires manual approval.');
+      action.addStep(step);
+    } else {
       step.error = true;
-      step.log(`Hook stderr: ${stderrTrimmed}`);
-      step.setError(stdoutTrimmed);
+      step.log(`Unexpected hook status: ${status}`);
+      step.setError(stdoutTrimmed || 'Unknown pre-receive hook error.');
       action.addStep(step);
-      return action;
     }
-
-    step.log('Pre-receive hook executed successfully');
-    action.addStep(step);
     return action;
   } catch (error) {
     step.error = true;
-    step.setError(`Hook execution error: ${error.message}`);
+    step.log('Push failed, pre-receive hook returned an error.');
+    step.setError(`Hook execution error: ${stderrTrimmed || error.message}`);
     action.addStep(step);
     return action;
   }

src/ui/views/PushDetails/PushDetails.jsx

@@ -173,45 +173,67 @@ export default function Dashboard() {
                     }}
                   >
                     <CheckCircle
-                      style={{ cursor: 'pointer', transform: 'scale(0.65)' }}
-                      onClick={() => setAttestation(true)}
+                      style={{
+                        cursor: data.autoApproved ? 'default' : 'pointer',
+                        transform: 'scale(0.65)',
+                        opacity: data.autoApproved ? 0.5 : 1,
+                      }}
+                      onClick={() => {
+                        if (!data.autoApproved) {
+                          setAttestation(true);
+                        }
+                      }}
                       htmlColor='green'
                     />
                   </span>
-                  <a href={`/admin/user/${data.attestation.reviewer.username}`}>
-                    <img
-                      style={{ width: '45px', borderRadius: '20px' }}
-                      src={`https://github.com/${data.attestation.reviewer.gitAccount}.png`}
-                    />
-                  </a>
-                  <div>
-                    <p>
+
+                  {data.autoApproved ? (
+                    <>
+                      <div style={{ paddingTop: '15px' }}>
+                        <p>
+                          <strong>Auto-approved by system</strong>
+                        </p>
+                      </div>
+                    </>
+                  ) : (
+                    <>
                       <a href={`/admin/user/${data.attestation.reviewer.username}`}>
-                        {data.attestation.reviewer.gitAccount}
-                      </a>{' '}
-                      approved this contribution
-                    </p>
-                    <Tooltip
-                      title={moment(data.attestation.timestamp).format(
-                        'dddd, MMMM Do YYYY, h:mm:ss a',
-                      )}
-                      arrow
-                    >
-                      <kbd
-                        style={{
-                          color: 'black',
-                          float: 'right',
-                        }}
-                      >
-                        {moment(data.attestation.timestamp).fromNow()}
-                      </kbd>
-                    </Tooltip>
-                  </div>
-                  <AttestationView
-                    data={data.attestation}
-                    attestation={attestation}
-                    setAttestation={setAttestation}
-                  />
+                        <img
+                          style={{ width: '45px', borderRadius: '20px' }}
+                          src={`https://github.com/${data.attestation.reviewer.gitAccount}.png`}
+                        />
+                      </a>
+                      <div>
+                        <p>
+                          <a href={`/admin/user/${data.attestation.reviewer.username}`}>
+                            {data.attestation.reviewer.gitAccount}
+                          </a>{' '}
+                          approved this contribution
+                        </p>
+                      </div>
+                    </>
+                  )}
+
+                  <Tooltip
+                    title={moment(data.attestation.timestamp).format(
+                      'dddd, MMMM Do YYYY, h:mm:ss a',
+                    )}
+                    arrow
+                  >
+                    <kbd style={{ color: 'black', float: 'right' }}>
+                      {moment(data.attestation.timestamp).fromNow()}
+                    </kbd>
+                  </Tooltip>
+
+                  {data.autoApproved ? (
+                    <></>
+                  ) : (
+                    <AttestationView
+                      data={data.attestation}
+                      attestation={attestation}
+                      setAttestation={setAttestation}
+                    />
+                  )}
                 </div>
               ) : null}
             </CardHeader>