-
Notifications
You must be signed in to change notification settings - Fork 130
feat: support direct querying of AD group membership via LDAP #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
- Coverage 49.65% 49.42% -0.24%
==========================================
Files 48 48
Lines 1718 1726 +8
Branches 175 175
==========================================
Hits 853 853
- Misses 841 849 +8
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed teh cypress test but am waiting on a review (in git proxy), will update monday with working cypress tests |
I'm not sure I can improve the test coverage on this - unless someone has a suggestion on mocking passport. We are however using it successfully this end. Configs were documented. Otherwise ready for review @JamieSlome |
@JamieSlome @grovesy @coopernetes Keen to get a review on this - also it should be tested by someone using a REST API to check group meembership. |
resolves #909
Adds support for using LDAP directly to confirm AD group membership, which is enabled when the
apis.ls
config is not set. Also adds documentations for the AD related parts of the config.