fix: push parsing drops commit messages unless they end in a newline #976
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
==========================================
+ Coverage 49.65% 50.87% +1.21%
==========================================
Files 48 48
Lines 1718 1724 +6
Branches 175 176 +1
==========================================
+ Hits 853 877 +24
+ Misses 841 818 -23
- Partials 24 29 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fixed the cypress test but am waiting on a review (in git proxy), will update monday with working cypress tests |
|
Code coverage is probably as good as I can get it - more to come on DB code coverage in #979 |
| return new Promise<void>((resolve, reject) => { | ||
| db.remove({ id }, (err) => { | ||
| if (err) { | ||
| reject(err); |
There was a problem hiding this comment.
I ignore lines like this in #979 for coverage as its hard to get neDB to actually throw an error without corrupting the database file.
| .slice(indexOfMessages + 1) | ||
| .join(' ').trim(); |
There was a problem hiding this comment.
This is the main change in this PR - the rest is all related to testing - although there is no direct testing of pushParsing currently implemented.
The change seems to resolve the issue for me on the PR where we had this issue (which was contributed without the problem message already).
|
@JamieSlome @grovesy @coopernetes This is ready for a review |
resolves #971
Adjusts push parsing to not require a newline at the end commit messages in order to capture them.
Also adjusts CLI tests to clean up the rows they create, so that they can be run multiple times without the DB files needing to be reset.