-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make filter and post-filter behavior clearer in query builder #2079
Conversation
🦋 Changeset detectedLatest commit: 245aac6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #2079 +/- ##
==========================================
- Coverage 39.64% 39.63% -0.02%
==========================================
Files 1539 1519 -20
Lines 72682 71649 -1033
Branches 17000 16748 -252
==========================================
- Hits 28816 28395 -421
+ Misses 43753 43139 -614
- Partials 113 115 +2
|
53d3bfd
to
f5b5d2c
Compare
packages/legend-query-builder/src/components/fetch-structure/QueryBuilderPostFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query-builder/src/components/fetch-structure/QueryBuilderPostFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query-builder/style/_query-builder-post-filter.scss
Outdated
Show resolved
Hide resolved
packages/legend-query-builder/src/components/filter/QueryBuilderFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query-builder/src/components/filter/QueryBuilderFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query-builder/src/components/fetch-structure/QueryBuilderPostFilterPanel.tsx
Outdated
Show resolved
Hide resolved
d038b64
to
9882d9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though you have some CI failures there. Also, it's a TODO that we think of the problem with DnD I told you a while back, can you file a Github issue for that? Thanks!
Added #2073 😃 |
Summary
fixes #1995
How did you test this change?