Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter and post-filter behavior clearer in query builder #2079

Merged
merged 7 commits into from
Jun 7, 2023

Conversation

xannem
Copy link
Contributor

@xannem xannem commented Apr 6, 2023

Summary

fixes #1995
Kapture 2023-05-14 at 14 34 39

Kapture 2023-05-14 at 14 59 40

  • allows drag and drop capabilities in post-filter panel by dragging the conditions themselves
  • allows drag and drop capabilities in filter panel by dragging the conditions themselves

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings) (ux changes)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

🦋 Changeset detected

Latest commit: 245aac6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-application-query-bootstrap Patch
@finos/legend-art Patch
@finos/legend-query-builder Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-application Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-manual-tests Patch
@finos/legend-application-studio-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xannem xannem self-assigned this Apr 6, 2023
@xannem xannem added Component: Query Builder Issues related to query builder core Component: UX/Design Issues related to UI/UX features and improvements, style system, and design principle labels Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #2079 (9882d9c) into master (f81e74c) will decrease coverage by 0.02%.
The diff coverage is 38.20%.

❗ Current head 9882d9c differs from pull request most recent head 245aac6. Consider uploading reports for the commit 245aac6 to get more accurate results

@@            Coverage Diff             @@
##           master    #2079      +/-   ##
==========================================
- Coverage   39.64%   39.63%   -0.02%     
==========================================
  Files        1539     1519      -20     
  Lines       72682    71649    -1033     
  Branches    17000    16748     -252     
==========================================
- Hits        28816    28395     -421     
+ Misses      43753    43139     -614     
- Partials      113      115       +2     
Impacted Files Coverage Δ
...ges/legend-art/src/panel/BlankPanelPlaceholder.tsx 23.91% <ø> (ø)
...ts/fetch-structure/QueryBuilderPostFilterPanel.tsx 10.50% <20.00%> (+0.27%) ⬆️
packages/legend-art/src/panel/PanelDropZone.tsx 9.52% <25.00%> (-0.48%) ⬇️
.../src/components/filter/QueryBuilderFilterPanel.tsx 54.37% <50.00%> (-3.21%) ⬇️
...omponents/fetch-structure/QueryBuilderTDSPanel.tsx 63.55% <75.00%> (-1.73%) ⬇️

... and 361 files with indirect coverage changes

@xannem xannem marked this pull request as ready for review April 6, 2023 20:18
@xannem xannem requested a review from a team as a code owner April 6, 2023 20:18
gayathrir11
gayathrir11 previously approved these changes Apr 10, 2023
@xannem xannem force-pushed the 0504dnd branch 2 times, most recently from 53d3bfd to f5b5d2c Compare April 12, 2023 22:32
@xannem xannem marked this pull request as draft May 3, 2023 17:46
@xannem xannem marked this pull request as ready for review May 14, 2023 18:33
@xannem xannem force-pushed the 0504dnd branch 2 times, most recently from d038b64 to 9882d9c Compare May 14, 2023 21:47
Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though you have some CI failures there. Also, it's a TODO that we think of the problem with DnD I told you a while back, can you file a Github issue for that? Thanks!

@xannem
Copy link
Contributor Author

xannem commented Jun 7, 2023

Looks good to me, though you have some CI failures there. Also, it's a TODO that we think of the problem with DnD I told you a while back, can you file a Github issue for that? Thanks!

Added #2073 😃

@akphi akphi merged commit dfc1ceb into finos:master Jun 7, 2023
@akphi akphi deleted the 0504dnd branch June 7, 2023 16:16
This was referenced Jun 7, 2023
@akphi akphi mentioned this pull request Jun 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Builder Issues related to query builder core Component: UX/Design Issues related to UI/UX features and improvements, style system, and design principle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Improve Query Builder UX
3 participants