Worked thru (again) "codelab-initial-state". #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elab-initial-state/public/js/homepage.js.
…uid == ownerUID, so now 2 pass, 2 fail, 1 pending.
… now 4 pass, 1 fail.
…malade-beta" as REAL_FIREBASE_PROJECT-ID in "test.js", and changed #182 "describe.skip" to "describe".
…lculateCart" so that all 5 tests now pass, and expanded console.log message in #51 to say "Cart total successfully recalculated!".
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Ok, so can git clone the repo and create an upstream as the source and an origin as the local, but cannot update local without CLA. |
|
Sorry, apparently I forked incorrectly? Doesn't matter; just git cloned for
learning.
…On Wed, Jul 3, 2024 at 5:31 PM google-cla[bot] ***@***.***> wrote:
Thanks for your pull request! It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation
<https://github.com/firebase/emulators-codelab/pull/29/checks?check_run_id=27017341536>
of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of
the pull request.
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZH6TFWI3KL3TBEUJK6CLZKRUUXAVCNFSM6AAAAABKKLEOXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGM2DOMBSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
(650) 336-8770
https://marmalade.ai
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.