-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return session future instead of session #6834
base: main
Are you sure you want to change the base?
Conversation
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (a0a02a7) and merge commit (528c8a7).Test Logs |
Test Results 18 files - 1 016 18 suites - 1 016 14s ⏱️ - 34m 5s Results for commit 5f1154b. ± Comparison against base commit a0a02a7. This pull request removes 5786 tests.
|
The public api surface has changed for the subproject firebase-vertexai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Size Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this manually?
@@ -48,6 +48,15 @@ public abstract class LiveSessionFutures internal constructor() { | |||
functionCallHandler: ((FunctionCallPart) -> FunctionResponsePart)? | |||
): ListenableFuture<Unit> | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could make the one above @JvmOverloads
and should work the same.
No description provided.