dataconnect: auth code internal cleanup #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f AtomicReference
…DataConnect.awaitAuthReady() and FirebaseDataConnect.awaitAppCheckReady()
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Test Results 66 files 66 suites 1m 18s ⏱️ Results for commit 12358d9. ♻️ This comment has been updated with latest results. |
Coverage Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectGrpcClient.kt:105
- Removing the suspend modifier from retryOnGrpcUnauthenticatedError could cause issues if the passed block requires suspension. Please verify that all invocations of this function do not expect suspend behavior.
private inline fun <T, R> T.retryOnGrpcUnauthenticatedError(
firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectCredentialsTokenManager.kt:190
- Using compareAndSet on a MutableStateFlow may not work as expected, since MutableStateFlow does not offer a standard compareAndSet API. Consider using the update() method to safely modify state.
if (state.compareAndSet(oldState, State.Closed)) {
aashishpatil-g
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and cleans up some of the code related to FirebaseAuth. The changes should have no effects whatsoever on users of the Firebase Data Connect Android Kotlin SDK.