Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconnect: dataconnect.yml: some minor improvements #6838

Merged
merged 8 commits into from
Apr 5, 2025

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 4, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

1 similar comment
Copy link
Contributor

github-actions bot commented Apr 4, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Test Results

 1 049 files  +   983   1 049 suites  +983   34m 46s ⏱️ + 33m 28s
 5 872 tests + 5 320   5 849 ✅ + 5 298  22 💤 +21  1 ❌ +1 
11 960 runs  +10 856  11 915 ✅ +10 813  44 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 821c9f4. ± Comparison against base commit 8af38c9.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 4, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 4, 2025

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.77% (8af38c9) to 45.77% (2b00c66) by +0.00%.

    FilenameBase (8af38c9)Merge (2b00c66)Diff
    DeleteMutation.java90.48%95.24%+4.76%
  • firebase-messaging

    Overall coverage changed from 84.13% (8af38c9) to 84.02% (2b00c66) by -0.11%.

    FilenameBase (8af38c9)Merge (2b00c66)Diff
    Metadata.java41.27%36.51%-4.76%
  • firebase-storage

    Overall coverage changed from 83.96% (8af38c9) to 84.37% (2b00c66) by +0.42%.

    FilenameBase (8af38c9)Merge (2b00c66)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.52%83.50%+1.98%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/78FH34pQSb.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 4, 2025

Startup Time Report 1

The report is too large (122,602 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/psNUtQmA5p/index.html

@dconeybe dconeybe marked this pull request as ready for review April 4, 2025 19:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@dconeybe dconeybe force-pushed the dconeybe/dataconnect/AdbGithubActionsFix branch from bf60482 to ebd6d02 Compare April 4, 2025 20:03
@dconeybe dconeybe changed the title dataconnect: dataconnect.yml: lots of improvements, especially terminating async commands dataconnect: dataconnect.yml: some minor improvements Apr 5, 2025
@dconeybe dconeybe merged commit 9a07498 into main Apr 5, 2025
423 of 429 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/AdbGithubActionsFix branch April 5, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants