Merge main into release

firebase · Jan 14, 2025 · 247627f · 247627f
2 parents e43d924 + 0755a72
commit 247627f
Show file tree

Hide file tree

Showing 62 changed files with 1,416 additions and 776 deletions.
diff --git a/.changeset/fluffy-rules-pretend.md b/.changeset/fluffy-rules-pretend.md
@@ -0,0 +1,6 @@
+---
+'@firebase/app-check': patch
+'@firebase/util': patch
+---
+
+Generate UUIDs with `crypto.randomUUID()` instead of custom uuidv4 function that uses `Math.random()`.
diff --git a/.changeset/hip-apricots-end.md b/.changeset/hip-apricots-end.md
@@ -0,0 +1,7 @@
+---
+'@firebase/remote-config-types': minor
+'@firebase/remote-config': minor
+'firebase': minor
+---
+
+Added support for custom signal targeting in Remote Config. Use `setCustomSignals` API for setting custom signals and use them to build custom targeting conditions in Remote Config.
diff --git a/.changeset/tame-tigers-approve.md b/.changeset/tame-tigers-approve.md
@@ -0,0 +1,6 @@
+---
+"@firebase/data-connect": minor
+"firebase": minor
+---
+
+Updated to include promise instead of promiselike
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -37,10 +37,10 @@ packages/messaging-interop-types @zwu52 @firebase/jssdk-global-approvers
 integration/messaging @zwu52 @firebase/jssdk-global-approvers
 
 # Auth Code
-packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
-packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
-packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
-packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @firebase/jssdk-global-approvers
+packages/auth @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
+packages/auth-compat @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
+packages/auth-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
+packages/auth-interop-types @lisajian @Xiaoshouzi-gh @sam-gc @pashanka @mansisampat @nhienlam @firebase/jssdk-global-approvers
 
 # Testing Code
 packages/rules-unit-testing  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers

diff --git a/.github/workflows/canary-deploy.yml b/.github/workflows/canary-deploy.yml
@@ -32,7 +32,7 @@ jobs:
         # Canary release script requires git history and tags.
         fetch-depth: 0
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Yarn install

diff --git a/.github/workflows/check-changeset.yml b/.github/workflows/check-changeset.yml
@@ -35,7 +35,7 @@ jobs:
         # This makes Actions fetch all Git history so check_changeset script can diff properly.
         fetch-depth: 0
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Yarn install

diff --git a/.github/workflows/check-docs.yml b/.github/workflows/check-docs.yml
@@ -28,7 +28,7 @@ jobs:
         # get all history for the diff
         fetch-depth: 0
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Yarn install

diff --git a/.github/workflows/check-pkg-paths.yml b/.github/workflows/check-pkg-paths.yml
@@ -28,7 +28,7 @@ jobs:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Yarn install

diff --git a/.github/workflows/deploy-config.yml b/.github/workflows/deploy-config.yml
@@ -36,7 +36,7 @@ jobs:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
     - name: Set up node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Yarn install

diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
@@ -50,6 +50,12 @@ jobs:
           TEST_ACCOUNT: ${{ secrets.TEST_ACCOUNT }}
         run: |
           echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
+      - name: Poll npm until version to test is available for install
+        run: |
+          echo "Polling npm for firebase@${{ github.event.client_payload.versionOrTag }}"
+          node ../scripts/release/poll-npm-publish.js
+        env:
+          VERSION: ${{ github.event.client_payload.versionOrTag }}
       - name: Yarn install
         run: |
           echo "Installing firebase@${{ github.event.client_payload.versionOrTag }}"

diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -32,7 +32,7 @@ jobs:
         # get all history for the diff
         fetch-depth: 0
     - name: Set up node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Yarn install

diff --git a/.github/workflows/health-metrics-pull-request.yml b/.github/workflows/health-metrics-pull-request.yml
@@ -38,8 +38,8 @@ jobs:
     if: (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 22.10.0
       - uses: 'google-github-actions/auth@v0'
@@ -55,8 +55,8 @@ jobs:
     if: (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 22.10.0
       - uses: 'google-github-actions/auth@v0'

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -22,9 +22,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: yarn install

diff --git a/.github/workflows/merge-release-branch.yml b/.github/workflows/merge-release-branch.yml
@@ -37,7 +37,7 @@ jobs:
         run: |
           echo "Merging release ${{ steps.get-version.outputs.RELEASE_VERSION }}"
       - name: Merge to main
-        uses: actions/github-script@v6
+        uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |

diff --git a/.github/workflows/prerelease-manual-deploy.yml b/.github/workflows/prerelease-manual-deploy.yml
@@ -35,7 +35,7 @@ jobs:
             # Canary release script requires git history and tags.
             fetch-depth: 0
         - name: Set up node (20)
-          uses: actions/setup-node@v3
+          uses: actions/setup-node@v4
           with:
             node-version: 22.10.0
         - name: Yarn install

diff --git a/.github/workflows/release-prod.yml b/.github/workflows/release-prod.yml
@@ -33,7 +33,7 @@ jobs:
 
     steps:
     - name: Set up node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Checkout release branch (with history)

diff --git a/.github/workflows/release-staging.yml b/.github/workflows/release-staging.yml
@@ -47,11 +47,11 @@ jobs:
     if: github.event.inputs.release-branch == 'release' || endsWith(github.event.inputs.release-branch, '-releasebranch')
     steps:
     - name: Set up node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Merge main into release
-      uses: actions/github-script@v6
+      uses: actions/github-script@v7
       with:
         github-token: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}
         script: |

diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml
@@ -39,9 +39,9 @@ jobs:
     - name: install Chrome stable
       run: |
         npx @puppeteer/browsers install chrome@stable
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Test setup and yarn install
@@ -57,7 +57,7 @@ jobs:
         gzip build.tar
     - name: Upload build archive
       if: ${{ !cancelled() }}
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
           name: build.tar.gz
           path: build.tar.gz
@@ -74,13 +74,13 @@ jobs:
       run: |
         npx @puppeteer/browsers install chrome@stable
     - name: Download build archive
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: build.tar.gz
     - name: Unzip build artifact
       run: tar xf build.tar.gz
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Test setup and yarn install
@@ -125,13 +125,13 @@ jobs:
       run: |
         echo $CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE
     - name: Download build archive
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: build.tar.gz
     - name: Unzip build artifact
       run: tar xf build.tar.gz
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Test setup and yarn install
@@ -165,13 +165,13 @@ jobs:
       run: |
         npx @puppeteer/browsers install chrome@stable
     - name: Download build archive
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: build.tar.gz
     - name: Unzip build artifact
       run: tar xf build.tar.gz
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Test setup and yarn install
@@ -209,13 +209,13 @@ jobs:
       run: |
         npx @puppeteer/browsers install chrome@stable
     - name: Download build archive
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: build.tar.gz
     - name: Unzip build artifact
       run: tar xf build.tar.gz
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - run: cp config/ci.config.json config/project.json

diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml
@@ -57,7 +57,7 @@ jobs:
           # This makes Actions fetch all Git history so run-changed script can diff properly.
           fetch-depth: 0
       - name: Set up Node (20)
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 22.10.0
       - name: Test setup and yarn install
@@ -70,26 +70,19 @@ jobs:
         run: xvfb-run yarn test:changed auth
   test-firefox:
     name: Test Auth on Firefox If Changed
-    # Whatever version of Firefox comes with 22.04 is causing Firefox
-    # startup to hang when launched by karma. Need to look further into
-    # why.
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: install Firefox stable
-        run: |
-          sudo apt-get update
-          sudo apt-get install firefox
-          sudo apt-get install wget
-
+        run: npx @puppeteer/browsers install firefox@stable
       - name: Checkout Repo
         uses: actions/checkout@v4
         with:
           # This makes Actions fetch all Git history so run-changed script can diff properly.
           fetch-depth: 0
       - name: Set up Node (20)
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 22.10.0
       - name: Test setup and yarn install

diff --git a/.github/workflows/test-changed-fcm-integration.yml b/.github/workflows/test-changed-fcm-integration.yml
@@ -39,7 +39,7 @@ jobs:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: Test setup and yarn install

diff --git a/.github/workflows/test-changed-firestore-integration.yml b/.github/workflows/test-changed-firestore-integration.yml
@@ -69,7 +69,7 @@ jobs:
       continue-on-error: true
 
     - name: Set up Node (20)
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v4
       with:
         node-version: 22.10.0
     - name: install Chrome stable