Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics consent updating (#8210) #8211

Closed

Conversation

megamisan
Copy link

  • Fix call to consent update after integrating rest operator for gtag wrapper.

Closes #8210

* Fix call to consent update after integrating rest operator for gtag wrapper.
@megamisan megamisan requested review from hsubox76 and a team as code owners April 27, 2024 18:43
Copy link

changeset-bot bot commented Apr 27, 2024

⚠️ No Changeset found

Latest commit: bbaec77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@megamisan
Copy link
Author

After testing the patch locally, I got the expected result.
Tag Assistant screenshot

@DellaBitta
Copy link
Contributor

Hi @megamisan,

Thanks for proposing this fix. We went a different route to fix the issue by updating the wrappedGtagFunction implementation, and keeping the invocation the same. Please see #8243.

I'm going to close this PR for now because I beleive it's not required anymore. Let me know if I closed it in error. Thanks again!

@DellaBitta DellaBitta closed this May 15, 2024
@firebase firebase locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics Consent not sent on update
2 participants