Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies in packages and repo-scripts #8729

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update dependencies in packages and repo-scripts #8729

wants to merge 6 commits into from

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jan 24, 2025 •
edited
Loading

This PR covers dependency updates in #5566 in the packages/ and repo-scripts/ directories (and some catchup in the main package.json).

Fixes that were needed:

  • rollup-plugin-typescript2 changes affect some packages and require explicitly excluding test files from the rollup build (tests are built with webpack in a separate process)
  • breaking typings changes in json-stable-stringify required some Firestore tweaks
  • bumping mocha-chai-jest-snapshot in api-documenter bumps a transitive dependency that has an unlisted dependency on jest-resolve. Added jest-resolve to get over this but what we really need is an overhaul and update of the api-documenter fork.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3d1727c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as draft January 24, 2025 20:11
@hsubox76 hsubox76 force-pushed the ch-packages-reposcripts branch from d574275 to 628189c Compare January 24, 2025 20:19
@hsubox76 hsubox76 force-pushed the ch-packages-reposcripts branch from 03d26e6 to b13f1a1 Compare January 27, 2025 20:53
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 27, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (99766e0)Merge (69f1b71)Diff
    browser19.2 kB19.5 kB+277 B (+1.4%)
    main20.1 kB20.4 kB+277 B (+1.4%)
    module19.2 kB19.5 kB+277 B (+1.4%)

  • @firebase/database-compat/standalone

    TypeBase (99766e0)Merge (69f1b71)Diff
    main365 kB366 kB+389 B (+0.1%)

  • @firebase/firestore

    TypeBase (99766e0)Merge (69f1b71)Diff
    main589 kB589 kB+1 B (+0.0%)

  • bundle

    46 size changes

    TypeBase (99766e0)Merge (69f1b71)Diff
    analytics (logEvent)44.6 kB44.7 kB+110 B (+0.2%)
    app-check (CustomProvider)37.3 kB37.4 kB+110 B (+0.3%)
    app-check (ReCaptchaEnterpriseProvider)39.8 kB39.9 kB+110 B (+0.3%)
    app-check (ReCaptchaV3Provider)39.8 kB39.9 kB+110 B (+0.3%)
    auth (Anonymous)76.4 kB76.6 kB+257 B (+0.3%)
    auth (EmailAndPassword)86.5 kB86.8 kB+257 B (+0.3%)
    auth (GoogleFBTwitterGitHubPopup)103 kB104 kB+257 B (+0.2%)
    auth (GooglePopup)100 kB101 kB+257 B (+0.3%)
    auth (GoogleRedirect)101 kB101 kB+257 B (+0.3%)
    auth (Phone)93.9 kB94.2 kB+257 B (+0.3%)
    database (Append to a list of data)149 kB150 kB+110 B (+0.1%)
    database (Filtering data)148 kB148 kB+110 B (+0.1%)
    database (Listen for child events)165 kB165 kB+110 B (+0.1%)
    database (Listen for value events + Detach listeners)165 kB165 kB+110 B (+0.1%)
    database (Listen for value events)165 kB165 kB+110 B (+0.1%)
    database (Read data once)164 kB164 kB+110 B (+0.1%)
    database (Save data as transactions)167 kB167 kB+110 B (+0.1%)
    database (Sort data)150 kB150 kB+110 B (+0.1%)
    database (Write data)149 kB149 kB+110 B (+0.1%)
    firestore (CSI Auto Indexing Disable and Delete)271 kB271 kB+110 B (+0.0%)
    firestore (CSI Auto Indexing Enable)271 kB271 kB+110 B (+0.0%)
    firestore (Persistence)302 kB302 kB+110 B (+0.0%)
    firestore (Query Cursors)249 kB249 kB+110 B (+0.0%)
    firestore (Query)247 kB247 kB+110 B (+0.0%)
    firestore (Read data once)235 kB235 kB+110 B (+0.0%)
    firestore (Read Write w Persistence)327 kB327 kB+110 B (+0.0%)
    firestore (Realtime updates)237 kB237 kB+110 B (+0.0%)
    firestore (Transaction)214 kB214 kB+110 B (+0.1%)
    firestore (Write data)214 kB214 kB+110 B (+0.1%)
    firestore-lite (Query Cursors)103 kB103 kB+110 B (+0.1%)
    firestore-lite (Query)99.1 kB99.2 kB+110 B (+0.1%)
    firestore-lite (Read data once)74.5 kB74.6 kB+110 B (+0.1%)
    firestore-lite (Transaction)99.8 kB99.9 kB+110 B (+0.1%)
    firestore-lite (Write data)84.1 kB84.2 kB+110 B (+0.1%)
    functions (call)34.7 kB34.8 kB+108 B (+0.3%)
    messaging (send + receive)47.4 kB47.5 kB+110 B (+0.2%)
    performance (trace)62.3 kB62.4 kB+110 B (+0.2%)
    remote-config (getAndFetch)47.5 kB47.7 kB+110 B (+0.2%)
    storage (getBytes)42.3 kB42.4 kB+110 B (+0.3%)
    storage (getDownloadURL)44.4 kB44.5 kB+110 B (+0.2%)
    storage (getMetadata)43.8 kB43.9 kB+110 B (+0.3%)
    storage (list + listAll)43.2 kB43.3 kB+110 B (+0.3%)
    storage (updateMetadata)44.1 kB44.2 kB+110 B (+0.2%)
    storage (uploadBytes)48.9 kB49.0 kB+110 B (+0.2%)
    storage (uploadBytesResumable)58.9 kB59.0 kB+110 B (+0.2%)
    storage (uploadString)49.1 kB49.3 kB+110 B (+0.2%)

  • firebase

    19 size changes

    TypeBase (99766e0)Merge (69f1b71)Diff
    firebase-analytics-compat.js26.5 kB25.7 kB-795 B (-3.0%)
    firebase-app-check-compat.js23.2 kB22.6 kB-615 B (-2.6%)
    firebase-app-compat.js32.3 kB31.8 kB-586 B (-1.8%)
    firebase-app.js102 kB103 kB+707 B (+0.7%)
    firebase-auth-compat.js143 kB139 kB-3.68 kB (-2.6%)
    firebase-auth-cordova.js136 kB136 kB+52 B (+0.0%)
    firebase-auth-web-extension.js119 kB119 kB+52 B (+0.0%)
    firebase-auth.js155 kB155 kB+52 B (+0.0%)
    firebase-compat.js808 kB791 kB-17.2 kB (-2.1%)
    firebase-database-compat.js166 kB164 kB-2.85 kB (-1.7%)
    firebase-firestore-compat.js345 kB338 kB-6.59 kB (-1.9%)
    firebase-functions-compat.js10.6 kB10.4 kB-254 B (-2.4%)
    firebase-installations-compat.js13.3 kB12.9 kB-384 B (-2.9%)
    firebase-messaging-compat.js38.7 kB37.0 kB-1.64 kB (-4.2%)
    firebase-performance-compat.js40.9 kB40.0 kB-868 B (-2.1%)
    firebase-performance-standalone-compat.js105 kB105 kB+115 B (+0.1%)
    firebase-remote-config-compat.js28.4 kB27.8 kB-564 B (-2.0%)
    firebase-storage-compat.js40.4 kB39.7 kB-690 B (-1.7%)
    firebase-vertexai.js24.0 kB24.2 kB+238 B (+1.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b9ekxRxPmd.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 27, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (212,901 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MZaM1SGaAl.html

@hsubox76 hsubox76 marked this pull request as ready for review January 29, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikeldridge erikeldridge Awaiting requested review from erikeldridge erikeldridge is a code owner

@jposuna jposuna Awaiting requested review from jposuna

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@yoyomyo yoyomyo Awaiting requested review from yoyomyo yoyomyo is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@mansisampat mansisampat Awaiting requested review from mansisampat mansisampat is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 is a code owner

@maneesht maneesht Awaiting requested review from maneesht maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubox76 @google-oss-bot