Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offppl type1 #8732

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
3b49905
wip: pipelines
MarkDuckworth Oct 14, 2024
a30f9ae
Fix circular deps
MarkDuckworth Oct 14, 2024
dbc7c12
Expose pipeline in lite-api
MarkDuckworth Oct 16, 2024
27213de
Refactoring to support lite-api
MarkDuckworth Oct 16, 2024
0676397
api-review folder updates
MarkDuckworth Oct 16, 2024
2cd396a
Adding missing protobufjs-cli
MarkDuckworth Oct 16, 2024
0c76ca0
Update API reports
MarkDuckworth Oct 16, 2024
5e9774b
fixes
MarkDuckworth Oct 16, 2024
22913b1
Merge branch 'markduckworth/ppl' of github.com:firebase/firebase-js-s…
MarkDuckworth Oct 16, 2024
2f3d48a
yarn.lock
MarkDuckworth Oct 16, 2024
076236e
Fixes. Passing integration tests.
MarkDuckworth Oct 28, 2024
8af0c57
Update API reports
MarkDuckworth Oct 28, 2024
57d1bf9
Move call to readUserData for code readability
MarkDuckworth Oct 29, 2024
022d276
Merge branch 'markduckworth/ppl' of github.com:firebase/firebase-js-s…
MarkDuckworth Oct 29, 2024
4f9a5fc
Made ProtoSerializable generic and used by Pipeline and Stage
MarkDuckworth Oct 29, 2024
6717ed4
Fixing build and lint issues
MarkDuckworth Oct 31, 2024
3ab4f5c
Update API reports
MarkDuckworth Oct 31, 2024
fc4f263
Merge branch 'main' of github.com:firebase/firebase-js-sdk into markd…
MarkDuckworth Oct 31, 2024
fd20eff
Adding new bundle size test
MarkDuckworth Oct 31, 2024
acbf24f
add pipeline to Listen RPC
wu-hui Oct 15, 2024
93fdb23
Prepre for serializaion/deserialization
wu-hui Oct 17, 2024
8ac835e
fix rebase error
wu-hui Oct 17, 2024
422723a
quick hack to integrate with watch.
wu-hui Oct 21, 2024
ee64690
add api/pipelinesource and setup basic listen test
wu-hui Oct 31, 2024
90a5e3c
experimentation with augmentation for ppl
MarkDuckworth Nov 4, 2024
585d52e
Update API reports
MarkDuckworth Nov 4, 2024
4b67f8a
Documentation and .d.ts improvements
MarkDuckworth Nov 5, 2024
26c76f3
Merge branch 'markduckworth/ppl-augment' of github.com:firebase/fireb…
MarkDuckworth Nov 5, 2024
ca0ffd9
Update API reports
MarkDuckworth Nov 5, 2024
1738c15
watch integration works.
wu-hui Nov 6, 2024
946a266
add pipeline canonify and eq
wu-hui Oct 22, 2024
6fc2050
runPipeline initial
wu-hui Oct 25, 2024
377e82f
initial offline function evaluation
wu-hui Oct 29, 2024
2b244a2
add basic tests for pipeline eval
wu-hui Oct 29, 2024
23b5135
runPipeline initial
wu-hui Oct 25, 2024
82b8303
Setting up QueryOrPipeline to replace Query
wu-hui Oct 30, 2024
2d386c8
Update the bundle definition for the pipeline bundle test
MarkDuckworth Nov 6, 2024
c621b81
Update the bundle definition adding a pipeline test with and function
MarkDuckworth Nov 6, 2024
773ab02
Typo
MarkDuckworth Nov 6, 2024
ad82093
Merge branch 'markduckworth/ppl-augment' of github.com:firebase/fireb…
MarkDuckworth Nov 6, 2024
682997d
And/or overloads. Pipeline serialization for console.
MarkDuckworth Nov 11, 2024
8eb9082
Cast Firestore
MarkDuckworth Nov 11, 2024
6a2abf3
And/or overloads
MarkDuckworth Nov 11, 2024
422cbd6
Update API reports
MarkDuckworth Nov 11, 2024
7a3e789
type1 compiles
wu-hui Nov 12, 2024
c78bae9
Fix and/or overloads
MarkDuckworth Nov 13, 2024
4d7d917
introduce new variant for query_engine.test.ts
wu-hui Nov 13, 2024
c274177
Fix core/expression rebase error
wu-hui Nov 13, 2024
56c4e4a
Merge branch 'markduckworth/ppl-augment' of github.com:firebase/fireb…
MarkDuckworth Nov 13, 2024
bcfaf2a
Modular-style pipeline and execute methods for experimentation. Plus …
MarkDuckworth Nov 13, 2024
5425705
Update API reports
MarkDuckworth Nov 13, 2024
9a1ffa6
Merge branch 'console' of github.com:firebase/firebase-js-sdk into fe…
MarkDuckworth Nov 13, 2024
edc1ea5
Docgen
MarkDuckworth Nov 13, 2024
6859582
Merge branch 'feat/pipelines' of github.com:firebase/firebase-js-sdk …
MarkDuckworth Nov 13, 2024
9c4d556
license headers
MarkDuckworth Nov 13, 2024
1aef450
docgen
MarkDuckworth Nov 13, 2024
b20afe6
docs-devsite fix
MarkDuckworth Nov 13, 2024
877bf3c
Skipping pipeline tests for CI
MarkDuckworth Nov 13, 2024
1f7b071
Update API reports
MarkDuckworth Nov 13, 2024
d9b6e9a
reverting changes to docs-devsite
MarkDuckworth Nov 13, 2024
18e3477
Merge branch 'feat/pipelines' of github.com:firebase/firebase-js-sdk …
MarkDuckworth Nov 13, 2024
703b18f
revert and/or overloads
MarkDuckworth Nov 13, 2024
75e35c8
Update API reports
MarkDuckworth Nov 13, 2024
6e4a7e3
Add basic tests
wu-hui Nov 14, 2024
e6f860e
remove api/pipeline and use the lite one
wu-hui Nov 14, 2024
4bb953a
Fix bundle definition
MarkDuckworth Nov 15, 2024
8b6855c
Merge branch 'feat/pipelines' of github.com:firebase/firebase-js-sdk …
MarkDuckworth Nov 15, 2024
92c651f
Fix imports
MarkDuckworth Nov 15, 2024
667c398
query_engine.test.ts pass with pipelines
wu-hui Nov 19, 2024
cc3146c
Re-adding circular dependency check.
MarkDuckworth Nov 19, 2024
d2e8d60
Addressing review comments.
MarkDuckworth Nov 19, 2024
fafadbc
PPL to Console (#8638)
MarkDuckworth Nov 20, 2024
0750f35
Merge branch 'console' of github.com:firebase/firebase-js-sdk into fe…
MarkDuckworth Nov 20, 2024
48a6324
local store tests PASS
wu-hui Nov 25, 2024
ecd931d
New bundle analysis to evaluate useFirestorePipelines vs execute
MarkDuckworth Nov 25, 2024
63b8854
Fix build. Finish rename. Rename useFirestorePipelines to useFluentPi…
MarkDuckworth Nov 26, 2024
6ab2ba5
memory spec tests pass sans limitToLast
wu-hui Nov 28, 2024
58124c4
most spec tests PASS!
wu-hui Dec 2, 2024
0f63a54
limit to last, cursors and multitab for documents and database stages
wu-hui Dec 4, 2024
5945776
Merge remote-tracking branch 'origin/feat/pipelines' into wuandy/offp…
wu-hui Dec 6, 2024
5ad944e
fix merge errors
wu-hui Dec 10, 2024
a9a0b82
Remove type references from the core Firestore API surface. This will…
MarkDuckworth Dec 10, 2024
da4dee3
Add expressions tests
wu-hui Dec 16, 2024
df90a2e
Fixes for Constant.of(...) (#8677)
MarkDuckworth Dec 18, 2024
656e848
Ported all tests, plus some bug fixes
wu-hui Dec 19, 2024
90ce598
Merge remote-tracking branch 'origin/feat/pipelines' into wuandy/offp…
wu-hui Dec 19, 2024
34b3e71
fix merge errors
wu-hui Dec 19, 2024
c5678fe
fixed expressions tests
wu-hui Dec 20, 2024
f2a0585
Fixed all incompatibilities
wu-hui Dec 23, 2024
bc9ac99
Add gitignore entries
wu-hui Dec 28, 2024
0212394
Merge with feat/pipelines
wu-hui Dec 28, 2024
52ebef6
Proto update sync and add query spec tests back
wu-hui Dec 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
local store tests PASS
  • Loading branch information
wu-hui committed Nov 25, 2024
commit 48a6324e1c2a0c836be5c8f4b17cebfaa7025bf7
2 changes: 1 addition & 1 deletion packages/firestore/src/core/pipeline_run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ function evaluateDocuments(
return input.filter(input => {
return (
input.isFoundDocument() &&
stage.docPaths.includes(input.key.path.canonicalString())
stage.docPaths.includes(input.key.path.toStringWithLeadingSlash())
);
});
}
Expand Down
18 changes: 0 additions & 18 deletions packages/firestore/src/local/local_store_impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -952,24 +952,6 @@ export function localStoreAllocateTarget(
target: Target | Pipeline
): Promise<TargetData> {
const localStoreImpl = debugCast(localStore, LocalStoreImpl);
if (targetIsPipelineTarget(target)) {
return localStoreImpl.persistence.runTransaction(
'Allocate pipeline target',
'readwrite',
txn => {
return localStoreImpl.targetCache
.allocateTargetId(txn)
.next(targetId => {
return new TargetData(
target,
targetId,
TargetPurpose.Listen,
txn.currentSequenceNumber
);
});
}
);
}

return localStoreImpl.persistence
.runTransaction('Allocate target', 'readwrite', txn => {
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/src/local/memory_persistence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ export class MemoryEagerDelegate implements MemoryReferenceDelegate {
const changeBuffer = cache.newChangeBuffer();
return PersistencePromise.forEach(
this.orphanedDocuments,
(path: string) => {
(path: string): PersistencePromise<void> => {
const key = DocumentKey.fromPath(path);
return this.isReferenced(txn, key).next(isReferenced => {
if (!isReferenced) {
Expand Down
4 changes: 4 additions & 0 deletions packages/firestore/src/model/path.ts
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,10 @@ export class ResourcePath extends BasePath<ResourcePath> {
return this.canonicalString();
}

toStringWithLeadingSlash(): string {
return `/${this.canonicalString()}`;
}

/**
* Returns a string representation of this path
* where each path segment has been encoded with
Expand Down
Loading
Loading