Change automaticDataCollectionEnabled to default to true. #8999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32e9eef The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vertex AI Mock Responses Check
|
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
dlarocque
approved these changes
May 6, 2025
Merged
hsubox76
added a commit
that referenced
this pull request
May 7, 2025
)" This reverts commit 3789b5a.
hsubox76
added a commit
that referenced
this pull request
May 7, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should default
automaticDataCollectionEnabledto true (it previously defaulted to false).This value is only consumed by App Check and Vertex.
App Check has been modified so that it retains the previous behavior (that automatic token refresh is off by default and will be turned on if
isTokenRefreshEnabledis explicitly set to true). The only unexpected behavior may be that settingisTokenRefreshEnabledwill do nothing ifautomaticDataCollectionEnabledis set to false. This is unlikely to happen as users rarely touchautomaticDataCollectionEnabledand this PR defaults it to true. I have added a logged warning just in case, but this is expected to be an edge case.This affects Vertex in that it allows sending data for AI monitoring by default.