-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud_firestore): Create a cloud_firestore_types
package that can be used in dart-only contexts
#13215
base: main
Are you sure you want to change the base?
Conversation
cloud_firestore_types
package that can be used in dart-only contextscloud_firestore_types
package that can be used in dart-only contexts
cloud_firestore_types
package that can be used in dart-only contextscloud_firestore_types
package that can be used in dart-only contexts
Meh I'm not sure this actually improves the state of things |
Actually I think having these available would help with json serialization |
|
I would like to include |
Hello @Rexios80, I'm not sure it will be used by other people and thus might not be useful to include it directly in the main FlutterFire repository. Would using a fork directly on your side be easier? |
@Lyokone If cloud_firestore doesn't use the types from this package then it might as well not exist. I plan on using these in my own published packages, so it needs to be published as well. I'm working on firebase_js_interop which allows you to write Firebase Cloud Functions in Dart. I hope that would be a popular enough use-case to warrant this change. This isn't the first time I've run into this issue, but last time I found a workaround. Having a cloud_firestore_types package would allow me to remove the workaround package firebase_rules_convert. I need to be able to create json converters from the cloud_firestore types to the js_interop types, but I can't do that since cloud_firestore depends on flutter. |
@Lyokone Do you need anything from me on this? |
Description
I am working on Dart code that gets transpiled to javascript. I'm having issues compiling because my model classes use these types, and thus transitively depend on Flutter.
Prequel to #13216
Related Issues
#13214
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?