-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Adding support for pre-commit linter and formatter based on ruff #1892
base: main
Are you sure you want to change the base?
Conversation
710addf
to
ef23ac6
Compare
ef23ac6
to
5e44bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have pre-commit checks in captainhook.json. Can you please use that? I don't want us to use 2 different sets of commands because some of us are working on both go and python. These pre-commit checks already exist?
Please edit this file: https://github.com/firebase/genkit/blob/main/py/captainhook.json for the changes
7774bc8
to
2ffe49b
Compare
2ffe49b
to
77ad22b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
77ad22b
to
de53535
Compare
de53535
to
ddc01f4
Compare
d00fd62
to
8eceb45
Compare
8eceb45
to
431a5d0
Compare
Checklist (if applicable):