fix(js/plugins/google-cloud): pass projectId through to GoogleAuth client #1907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - testing in progress
I saw a bug in Discord where
projectId
being set in the options was not respected; in the end an alternative solution was found. After working on refactoring the docs, I realized we are not appropriately passingprojectId
along to the GoogleAuth client.The specific use case is as follows: If the developer provides an external credential (either via
credentials
option, or via env variable) they must also provide the targetprojectId
to the client.In all other cases,
projectId
should be available and inferred from the client, as it will not work without theprojectId
set.One possible point of confusion seems to arise with local user auth in development (i.e.
gcloud auth application-default login
). In this case,projectId
might not be set. The solution is to provide it during auth (--project)
, set the gcloud cli default project, or set the environment variable GCLOUD_PROJECT.Checklist (if applicable):