fix(mypy): 1/2 mypy complains about conflicting main.py modules if we do not use unique names for the sample modules #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do not use unique names for the sample modules ERROR: ``` samples/coffee-shop/main.py: error: Duplicate module named "main" (also at "./samples/basic-gemini/main.py") samples/coffee-shop/main.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info samples/coffee-shop/main.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH ``` CHANGELOG: - [ ] Use the same structure as other packages with unambiguous names for entry point modules to avoid collisions to satisfy mypy. - [ ] Enable strict mypy checks by default; relax as necessary.
yesudeep
requested review from
tanyasingh1902,
Manurajbharath,
Irillit and
kirgrim
tanyasingh1902
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERROR:
CHANGELOG:
for entry point modules to avoid collisions to satisfy mypy.