-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[firebaseai] Turn on request logging #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @paulb777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request enables request logging for the Firebase AI example app. It adds the -FIRDebugEnabled
command line argument to the build scheme, which logs server requests to the console. It also updates the README to explain how to enable/disable request logging.
Highlights
- Enable Request Logging: The primary goal is to turn on request logging for debugging purposes in the Firebase AI example app.
- Command Line Argument: The
-FIRDebugEnabled
argument is added to the build scheme to enable logging. - README Update: The README is updated to provide instructions on how to enable or disable request logging.
Changelog
- firebaseai/FirebaseAIExample.xcodeproj/xcshareddata/xcschemes/FirebaseAIExample (iOS).xcscheme
- Added
-FIRDebugEnabled
command line argument to the scheme to enable request logging.
- Added
- firebaseai/README.md
- Added a section explaining how to enable/disable request logging using the
-FIRDebugEnabled
option.
- Added a section explaining how to enable/disable request logging using the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Logs whisper secrets untold,
In console's depths, stories unfold.
-FIRDebugEnabled
's call,
Reveals the server's thrall,
Insights emerge, brave and bold.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a command line argument to the build scheme to enable request logging and updates the README to reflect this change. The changes are straightforward and seem reasonable.
Merge Readiness
The changes are simple and well-documented. I don't see any immediate issues that would block merging. However, I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.