Skip to content

[firebaseai] Remove dependencies not necessary for getting started #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented May 1, 2025

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @paulb777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request aims to remove unnecessary dependencies from the FirebaseAI example project to simplify the getting started experience. I have removed the FirebaseAppCheck, FirebaseAuth, and FirebaseStorage dependencies, along with the associated code related to App Check, from the project's configuration and source files.

Highlights

  • Dependency Removal: Removed FirebaseAppCheck, FirebaseAuth, and FirebaseStorage dependencies from the project.
  • Project Configuration Update: Updated the project's pbxproj file to remove references to the removed dependencies.
  • Code Cleanup: Removed App Check related code from FirebaseAISampleApp.swift.

Changelog

  • firebaseai/FirebaseAIExample.xcodeproj/project.pbxproj
    • Removed FirebaseAppCheck, FirebaseAuth, and FirebaseStorage frameworks from build files.
    • Removed FirebaseAppCheck, FirebaseAuth, and FirebaseStorage from package product dependencies.
    • Removed XCSwiftPackageProductDependency entries for FirebaseAppCheck, FirebaseAuth, and FirebaseStorage.
  • firebaseai/FirebaseAISample/FirebaseAISampleApp.swift
    • Removed import FirebaseAppCheck.
    • Removed AppCheck configuration code.
    • Removed AppCheckNotConfiguredFactory and AppCheckNotConfigured error.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Dependencies trimmed with care,
To simplify, the project's air.
Less to impede,
For users to read,
A smoother start, beyond compare.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request aims to remove unnecessary dependencies to simplify the getting started experience with the FirebaseAI example app. This is a good step towards making the project more accessible. The changes primarily involve removing Firebase App Check, Authentication, and Storage dependencies. Overall, the changes seem reasonable and contribute to the stated goal.

Merge Readiness

The pull request removes dependencies to simplify the getting started experience. Given the review settings, I did not add comments for low or medium severity issues, but I also did not find any high or critical severity issues. Therefore, I recommend that the pull request is ready to be merged, but I am unable to directly approve the pull request and users should have others review and approve this code before merging.

@paulb777 paulb777 requested a review from andrewheard May 1, 2025 23:38
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul! This will definitely clean up the extraneous console output too.

@paulb777
Copy link
Member Author

paulb777 commented May 2, 2025

Yep. I confirmed the console is cleaner. Thanks for the suggestion!

@paulb777 paulb777 merged commit 3ac4cd6 into main May 2, 2025
6 checks passed
@paulb777 paulb777 deleted the pb-simplify-deps branch May 2, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants