Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4768: Don't check KVM in tools/devtool checkstyle #4868

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

tommady
Copy link
Contributor

@tommady tommady commented Oct 23, 2024

Changes

Introducing a new flag, do_kvm_check, within cmd_test to manage cmd_checkstyle, allowing the bypass of KVM checks as outlined in the PR.
...

Reason

to address issue 4768 #4768
...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@tommady tommady force-pushed the address-issue-4768 branch from 3fe3576 to 5d3e150 Compare October 23, 2024 03:58
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (8c8ee32) to head (0aff83b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4868   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files         251      251           
  Lines       28052    28052           
=======================================
  Hits        23586    23586           
  Misses       4466     4466           
Flag Coverage Δ
5.10-c5n.metal 84.71% <ø> (ø)
5.10-m5n.metal 84.69% <ø> (ø)
5.10-m6a.metal 84.00% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.70% <ø> (ø)
5.10-m6i.metal 84.69% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.70% <ø> (ø)
6.1-c5n.metal 84.71% <ø> (ø)
6.1-m5n.metal 84.69% <ø> (ø)
6.1-m6a.metal 84.00% <ø> (ø)
6.1-m6g.metal 80.69% <ø> (-0.01%) ⬇️
6.1-m6i.metal 84.70% <ø> (+<0.01%) ⬆️
6.1-m7g.metal 80.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this! The changes themselves look good, but could you address the style check failing in CI? Generally, the commit message should be a bit more descriptive, with a title summarizing what the change is, and the body motivating why we're doing this change. And with this PR, you should be able to run the style checks locally on your machine without problem now :D

@tommady tommady changed the title address issue 4768 #4768: Don't check KVM in tools/devtool checkstyle Oct 23, 2024
@tommady tommady force-pushed the address-issue-4768 branch 2 times, most recently from b24008a to 9f16d5b Compare October 23, 2024 10:19
add a new flag do_kvm_check within cmd_test to manage cmd_checkstyle

Signed-off-by: tommady <[email protected]>
@tommady tommady force-pushed the address-issue-4768 branch from 9f16d5b to 0aff83b Compare October 23, 2024 10:32
@tommady
Copy link
Contributor Author

tommady commented Oct 23, 2024

@roypat, thanks for your guide. I addressed your comment and ran the style check command successfully on local. Please review it again when you have time. thx

Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pb8o pb8o merged commit 5ef02a8 into firecracker-microvm:main Oct 23, 2024
6 of 7 checks passed
@tommady tommady deleted the address-issue-4768 branch October 23, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants