-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4768: Don't check KVM in tools/devtool checkstyle #4868
Conversation
3fe3576
to
5d3e150
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4868 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 251 251
Lines 28052 28052
=======================================
Hits 23586 23586
Misses 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this! The changes themselves look good, but could you address the style check failing in CI? Generally, the commit message should be a bit more descriptive, with a title summarizing what the change is, and the body motivating why we're doing this change. And with this PR, you should be able to run the style checks locally on your machine without problem now :D
b24008a
to
9f16d5b
Compare
add a new flag do_kvm_check within cmd_test to manage cmd_checkstyle Signed-off-by: tommady <[email protected]>
9f16d5b
to
0aff83b
Compare
@roypat, thanks for your guide. I addressed your comment and ran the style check command successfully on local. Please review it again when you have time. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes
Introducing a new flag, do_kvm_check, within cmd_test to manage cmd_checkstyle, allowing the bypass of KVM checks as outlined in the PR.
...
Reason
to address issue 4768 #4768
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.