fix: devtool install --path broken #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
reviewed
Nov 5, 2024
mpbb
force-pushed
the
fix-devtool-install
branch
from
f72280d to
5c7ddaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4890 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 251 251
Lines 28067 28067
=======================================
Hits 23597 23597
Misses 4470 4470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pb8o
reviewed
Nov 11, 2024
mpbb
force-pushed
the
fix-devtool-install
branch
2 times, most recently
from
c371994 to
fddf4f0
Compare
pb8o
added
Type: Fix
|
@mpbb It looks like our style checks fail. Could you change the commit body to have lines shorter than 72 characters? I usually do Sorry about that. |
ensures binaries are installed in the directory specified by --path. previously binaries could be overwriten during installation. Signed-off-by: Matthew Buckingham-Bishop <[email protected]>
mpbb
force-pushed
the
fix-devtool-install
branch
from
7fc67c9 to
41f1bea
Compare
|
@pb8o Thanks for your help, fixed my commit message. |
roypat
approved these changes
Nov 20, 2024
pb8o
approved these changes
Nov 20, 2024
|
Merged! Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures binaries are installed in the directory specified by --path.
Previously if --path specified a non existent directory it would create a single file.
Changes
When using
devtool install --pathinterpret the path as a directory and create one if it does not exist....
Reason
Previously
devtool install --pathwould attempt to install all binaries, usingpathas a file name ifpathwas not the name of a directory....
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.