refactor: Remove some getters and setters for boot_source #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialization code for the `boot_source` field in `build_boot_source` had me do a double take when I first saw, with all the setters and getters obscuring what is really happening. Clean this up by simply using a struct initializer, and also remove the getters and setters altogether, since all the fields are pub anyway. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4917 +/- ##
==========================================
- Coverage 84.09% 84.08% -0.01%
==========================================
Files 251 251
Lines 28061 28058 -3
==========================================
- Hits 23597 23592 -5
- Misses 4464 4466 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
roypat
added
the
Status: Awaiting review
JackThomson2
approved these changes
Nov 20, 2024
ShadowCurse
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization code for the
boot_sourcefield inbuild_boot_sourcehad me do a double take when I first saw, with all the setters and getters obscuring what is really happening. Clean this up by simply using a struct initializer, and also remove the getters and setters altogether, since all the fields are pub anyway.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.