Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): add switch case for AMD_GENOA to the cpu features test #4949

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ShadowCurse
Copy link
Contributor

Changes

During previous refactoring, this switch was accidentally removed.

Reason

We need this for pipelines not to fail.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse self-assigned this Dec 6, 2024
During previous refactoring, this switch was accidentally removed.

Signed-off-by: Egor Lazarchuk <[email protected]>
@ShadowCurse ShadowCurse added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code labels Dec 6, 2024
@ShadowCurse ShadowCurse requested a review from pb8o December 6, 2024 14:02
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (1f94a59) to head (609f455).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4949   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files         251      251           
  Lines       28059    28059           
=======================================
  Hits        23592    23592           
  Misses       4467     4467           
Flag Coverage Δ
5.10-c5n.metal 84.65% <ø> (ø)
5.10-m5n.metal 84.63% <ø> (-0.01%) ⬇️
5.10-m6a.metal 83.93% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.74% <ø> (ø)
5.10-m6i.metal 84.62% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.74% <ø> (ø)
6.1-c5n.metal 84.65% <ø> (ø)
6.1-m5n.metal 84.63% <ø> (ø)
6.1-m6a.metal 83.93% <ø> (ø)
6.1-m6g.metal 80.74% <ø> (ø)
6.1-m6i.metal 84.62% <ø> (ø)
6.1-m7g.metal 80.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o merged commit 761909d into firecracker-microvm:main Dec 6, 2024
9 checks passed
@ShadowCurse ShadowCurse deleted the return_of_amd_genoa branch December 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants