-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rare failure in pause resume test #5011
Merged
JackThomson2
merged 1 commit into
firecracker-microvm:main
from
JackThomson2:fix/kvmclock_ctrl_test
Feb 6, 2025
Merged
fix: Rare failure in pause resume test #5011
JackThomson2
merged 1 commit into
firecracker-microvm:main
from
JackThomson2:fix/kvmclock_ctrl_test
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5011 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 245 245
Lines 26647 26647
=======================================
Hits 22161 22161
Misses 4486 4486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Manciukic
previously approved these changes
Jan 24, 2025
pb8o
reviewed
Jan 24, 2025
d7d6f07
to
2d22702
Compare
roypat
previously approved these changes
Feb 6, 2025
kalyazin
reviewed
Feb 6, 2025
Test with 1 vCPU when running the KVMCLOCK_CTRL tests so we don't error on intermittent issue with the soft lockup watchdog. Signed-off-by: Jack Thomson <[email protected]>
2c7ce65
to
e033b28
Compare
kalyazin
approved these changes
Feb 6, 2025
roypat
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test with 1 vCPU when running the KVMCLOCK_CTRL tests so we don't fail on intermittent issue with clock.
Confirmed with the KVMCLOCK_CTR call removed the test still fails after the update.
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.