Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rare failure in pause resume test #5011

Merged

Conversation

JackThomson2
Copy link
Contributor

@JackThomson2 JackThomson2 commented Jan 24, 2025

Changes

Test with 1 vCPU when running the KVMCLOCK_CTRL tests so we don't fail on intermittent issue with clock.

Confirmed with the KVMCLOCK_CTR call removed the test still fails after the update.

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@JackThomson2 JackThomson2 changed the title fix: Fix rare failure in pause resume test fix: Rare failure in pause resume test Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (567b1ea) to head (e033b28).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5011   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files         245      245           
  Lines       26647    26647           
=======================================
  Hits        22161    22161           
  Misses       4486     4486           
Flag Coverage Δ
5.10-c5n.metal 83.61% <ø> (ø)
5.10-m5n.metal 83.59% <ø> (ø)
5.10-m6a.metal 82.80% <ø> (ø)
5.10-m6g.metal 79.59% <ø> (ø)
5.10-m6i.metal 83.58% <ø> (?)
5.10-m7g.metal 79.59% <ø> (ø)
6.1-c5n.metal 83.61% <ø> (ø)
6.1-m5n.metal 83.59% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.80% <ø> (ø)
6.1-m6g.metal 79.59% <ø> (ø)
6.1-m6i.metal 83.58% <ø> (ø)
6.1-m7g.metal 79.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackThomson2 JackThomson2 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jan 24, 2025
Manciukic
Manciukic previously approved these changes Jan 24, 2025
roypat
roypat previously approved these changes Feb 6, 2025
Test with 1 vCPU when running the KVMCLOCK_CTRL tests so we don't error
on intermittent issue with the soft lockup watchdog.

Signed-off-by: Jack Thomson <[email protected]>
@JackThomson2 JackThomson2 merged commit 89f2cb2 into firecracker-microvm:main Feb 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants