Fix(test): have codecov uploader exit with non-zero code on error #5016
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
force-pushed
the
fix-codecov
branch
4 times, most recently
from
bb801d6 to
0c80913
Compare
roypat
changed the title
Pass the `-Z` flag (fail on error) to the codecov uploader. According to the docs, without this flag upload failures will be silently ignored (why isn't this the default??) [1]. We can also see this from the logs, which contain: ``` [2025-01-28T12:10:57.973Z] ['info'] Codecov will exit with status code 0. If you are expecting a non-zero exit code, please pass in the `-Z` flag ``` The docs say that a long form `--fail-on-error` is available, but actually it doesnt seem to work, so we have to use `-Z`. [1]: https://docs.codecov.com/docs/cli-options Signed-off-by: Patrick Roy <[email protected]>
pb8o
approved these changes
Jan 28, 2025
roypat
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5016 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 245 245
Lines 26697 26697
=======================================
Hits 22194 22194
Misses 4503 4503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulinx86
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the
-Zflag (fail on error) to the codecov uploader. According tothe docs, without this flag upload failures will be silently ignored
(why isn't this the default??) 1. We can also see this from the logs,
which contain:
The docs say that a long form
--fail-on-erroris available, but actuallyit doesnt seem to work, so we have to use
-Z.example of it failing: https://buildkite.com/firecracker/firecracker-pr/builds/12416#0194ad35-9532-409d-b90b-1a05c3f80cc1
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.