Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ab): unignore m6g/5.10 block #5032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Feb 7, 2025

Changes

m6g/5.10 block throughput results are no longer volatile, so we can reinsert it to the A/B testing.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [ ] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [ ] I have mentioned all user-facing changes in CHANGELOG.md.
  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [ ] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

m6g/5.10 block throughput results are no longer volatile, so we can
reinsert it to the A/B testing.

Signed-off-by: Nikita Kalyazin <[email protected]>
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (89f2cb2) to head (785b3b8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5032   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files         245      245           
  Lines       26647    26647           
=======================================
  Hits        22161    22161           
  Misses       4486     4486           
Flag Coverage Δ
5.10-c5n.metal 83.61% <ø> (+<0.01%) ⬆️
5.10-m5n.metal 83.60% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.80% <ø> (ø)
5.10-m6g.metal 79.59% <ø> (ø)
5.10-m6i.metal 83.58% <ø> (ø)
5.10-m7g.metal 79.59% <ø> (ø)
6.1-c5n.metal 83.60% <ø> (ø)
6.1-m5n.metal 83.59% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.80% <ø> (ø)
6.1-m6g.metal 79.59% <ø> (ø)
6.1-m6i.metal 83.58% <ø> (ø)
6.1-m7g.metal 79.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalyazin kalyazin self-assigned this Feb 7, 2025
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant