fix(ghost): voting xepoch & polish #3890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidatong
force-pushed
the
chali/feat/ghost
branch
from
4afe140 to
aa4bcd8
Compare
|
|
||
| void | ||
| fd_ghost_replay_vote( fd_ghost_t * ghost, fd_voter_t * voter, ulong slot ) { | ||
| replay_vote( ghost, &voter->key, voter->stake, voter->replay_vote, voter->stake, slot ); | ||
| voter->replay_vote = slot; /* update the cached replay vote slot on voter */ |
There was a problem hiding this comment.
It seems like now voter->replay_vote will update to slot even when the if( ( slot <= last_slot ) ) return; condition is hit and we aren't actually updating to this slot.
lidatong
force-pushed
the
chali/feat/ghost
branch
from
aa4bcd8 to
71da0ff
Compare
lidatong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.