snapshot: fix incremental snapshot loading #3983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
reviewed
Jan 22, 2025
ripatel-fd
reviewed
Jan 22, 2025
Comment on lines
+146
to
+135
| int do_restore_manifest, | ||
| int do_restore_status_cache ) { |
There was a problem hiding this comment.
I suggest using flags here. It's easier to extend in the future and the call sites become more readable.
fd_snapshot_load_manifest_and_status_cache(ctx,1,1) becomes fd_snapshot_load_manifest_and_status_cache(ctx, FD_SNAPSHOT_RESTORE_MANIFEST|FD_SNAPSHOT_RESTORE_STATUS_CACHE)
There was a problem hiding this comment.
(In case Agave prepends yet another data structure)
topointon-jump
force-pushed
the
topointon/fix-snapshot-load
branch
from
1f496e1 to
4b90878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where we have an incremental snapshot, the status cache and the slot context were first being initialized from the incremental snapshot preflight manifest load, and then again when we loaded the full snapshot manifest.
This meant that the validators slot number is set first to the incremental snapshots slot number, then jumps back to the full snapshots slot number. This causes repair to get stuck in a loop.
Therefore, if we have an incremental snapshot this PR skips initializing the status cash and the slot context when we load in the full snapshot - because these will have already been initialized by the incremental snapshot preflight manifest load.