Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Constants #105

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix Constants #105

merged 1 commit into from
Dec 17, 2024

Conversation

pbrubeck
Copy link
Collaborator

Some attempts to optimize by introducing tensor-valued Constants

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/constants branch 2 times, most recently from b057a18 to 6951a95 Compare December 17, 2024 03:29
@pbrubeck pbrubeck force-pushed the pbrubeck/fix/constants branch from 6951a95 to 9a4bca4 Compare December 17, 2024 03:30
rckirby
rckirby approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this gets tests down to 4 minutes from 4.5, probably will help out on more complicated problems down the road!

@rckirby rckirby merged commit ac6fdf9 into smaclachlan/the_other_git Dec 17, 2024
2 checks passed
@rckirby rckirby deleted the pbrubeck/fix/constants branch December 17, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rckirby rckirby rckirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbrubeck @rckirby